Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate --lock-write flag #24436

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jul 4, 2024

This commit deprecates --lock-write flag by removing it from
the help output and printing a warning message when it's used.

Users should use --frozen=false instead which was added
in #24355.

Towards #24167.

@bartlomieju bartlomieju added this to the 1.45 milestone Jul 4, 2024
@bartlomieju bartlomieju merged commit 0bbfd6f into denoland:main Jul 5, 2024
17 checks passed
@bartlomieju bartlomieju deleted the deprecate_lock_write branch July 5, 2024 02:38
@bartlomieju bartlomieju mentioned this pull request Jul 6, 2024
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
This commit deprecates `--lock-write` flag by removing it from
the help output and printing a warning message when it's used.

Users should use `--frozen=false` instead which was added
in denoland#24355.

Towards denoland#24167.
@pihentagy
Copy link

pihentagy commented Aug 14, 2024

Nice, but --lock-write is still promoted in deno 1.45.5 when it figures out the source has changed:

pihentagy@dell:~/prg/example-project-for-zephyr$ deno cache --reload https://raw.githubusercontent.com/pihentagy/whatever
error: Integrity check failed for remote specifier. The source code is invalid, as it does not match the expected hash in the lock file.

  Specifier: https://googleapis.deno.dev/v1/sheets:v4.ts
  Actual: 28e9ab0ccbaac84b5a1f75f04aa361286e45f1aad864065516cc2c63ffdf89d2
  Expected: a1c80381d2dd3a74d1fd80f36e3f3a52b4945411904ca24eadd3a392e5bf8d0b

This could be caused by:
  * the lock file may be corrupt
  * the source itself may be corrupt

Use the --lock-write flag to regenerate the lockfile or --reload to reload the source code from the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants