fix(node): Implement fs.lchown (and process.getegid)
#24418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
changed the title
fs.lchown (and process.getegid)fs.lchown (and process.getegid)
littledivy
reviewed
Jul 4, 2024
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
) Closes denoland#21260. Part of denoland#18218. Implements `node:fs.lchown`, and enables the node_compat test for it. The test uses `process.getegid`, which we didn't have implemented, so I went ahead and implemented that as well to get the test working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21260.
Part of #18218.
Implements
node:fs.lchown, and enables the node_compat test for it. The test usesprocess.getegid, which we didn't have implemented, so I went ahead and implemented that as well to get the test working.