-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli/tools): add a subcommand --hide-stacktraces
for test
#24095
feat(cli/tools): add a subcommand --hide-stacktraces
for test
#24095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a couple comments. Sorry for the slow review.
cli/args/flags.rs
Outdated
@@ -2683,6 +2684,12 @@ Note: running multiple `deno test --clean` calls in series or parallel for the s | |||
.help("Select reporter to use. Default to 'pretty'.") | |||
.value_parser(["pretty", "dot", "junit", "tap"]) | |||
) | |||
.arg( | |||
Arg::new("hide-traces") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename this option to --hide-stacktraces
?
remove unnecessary attribute Co-authored-by: Luca Casonato <[email protected]> Signed-off-by: Hajime-san <[email protected]>
--hide-traces
for test--hide-stacktraces
for test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@dsherret |
resolves #24002
I implemented this suggestion that I think it sounds reasonable for reducing noise.
Also, this feature could hide stack trace when running test from editor with LSP command by internal code updated, however I don't touch it currently.
example
before
after