-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to reqwest 0.12.4 and rustls 0.22 #24056
Conversation
To avoid duplicate winreg crate in #24056
To avoid duplicate winreg crate in #24056 --------- Co-authored-by: Bartek Iwańczuk <[email protected]>
Failing test is due to this change in hyper: seanmonstar/reqwest#2207 My two cents: seanmonstar/reqwest#2240 (comment)
EDIT: My bad, I misinterpreted the issue - we're now adding EDIT2: It was already reverted in hyper 1.3.1, so upgrading to that will fix this. Sorry for the noise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Divy Srivastava <[email protected]> Signed-off-by: Ryan Dahl <[email protected]>
Co-authored-by: Divy Srivastava <[email protected]> Signed-off-by: Bartek Iwańczuk <[email protected]>
This commit updates Deno to use `reqwest` at 0.12.4 and `rustls` at 0.22. Other related crates were updated as well to match versions accepted by `reqwest` and `rustls`. Note: we are not using the latest available `rustls` yet, but this upgrade was non-trivial already, so a bump to 0.23 for `rustls` will be done in a separate commit. Closes #23370 --------- Signed-off-by: Ryan Dahl <[email protected]> Signed-off-by: Bartek Iwańczuk <[email protected]> Co-authored-by: Ryan Dahl <[email protected]> Co-authored-by: Divy Srivastava <[email protected]>
)" This reverts commit fb31eaa.
…oland#24056)" (denoland#24262)" This reverts commit b94707a.
Reland of #24056 that doesn't suffer from the problem that was discovered in #24261. It uses upgraded `hyper` and `hyper-util` that fixed the previous problem in hyperium/hyper#3691.
)" (denoland#24262) This reverts commit fb31eaa. Reverting because users reported spurious errors when downloading dependencies - denoland#24260. Closes denoland#24260
Reland of denoland#24056 that doesn't suffer from the problem that was discovered in denoland#24261. It uses upgraded `hyper` and `hyper-util` that fixed the previous problem in hyperium/hyper#3691.
This commit updates Deno to use `reqwest` at 0.12.4 and `rustls` at 0.22. Other related crates were updated as well to match versions accepted by `reqwest` and `rustls`. Note: we are not using the latest available `rustls` yet, but this upgrade was non-trivial already, so a bump to 0.23 for `rustls` will be done in a separate commit. Closes denoland#23370 --------- Signed-off-by: Ryan Dahl <[email protected]> Signed-off-by: Bartek Iwańczuk <[email protected]> Co-authored-by: Ryan Dahl <[email protected]> Co-authored-by: Divy Srivastava <[email protected]>
)" (denoland#24262) This reverts commit fb31eaa. Reverting because users reported spurious errors when downloading dependencies - denoland#24260. Closes denoland#24260
Reland of denoland#24056 that doesn't suffer from the problem that was discovered in denoland#24261. It uses upgraded `hyper` and `hyper-util` that fixed the previous problem in hyperium/hyper#3691.
This commit updates Deno to use
reqwest
at 0.12.4and
rustls
at 0.22. Other related crates were updatedas well to match versions accepted by
reqwest
andrustls
.Note: we are not using the latest available
rustls
yet,but this upgrade was non-trivial already, so a bump to
0.23 for
rustls
will be done in a separate commit.Closes #23370