Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate deno vendor #22183

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jan 30, 2024

Closes #20584

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's hold off on merging this until we get support in Deploy.

@lino-levan
Copy link
Contributor

Why is this being deprecated? We need this to publish to JSR as far as I am aware? Happy to be wrong about that.

@dsherret
Copy link
Member

@lino-levan yeah, that might keep this built-in. Please comment with use cases in #20584

@bartlomieju bartlomieju modified the milestones: 1.42, 2.0 Mar 6, 2024
@bartlomieju bartlomieju modified the milestones: 2.0, 1.45 Jul 9, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit eb46296 into denoland:main Jul 10, 2024
17 checks passed
@iuioiua iuioiua deleted the deprecate-vendor branch July 12, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate deno vendor and replace with "vendor": true?
4 participants