Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): properly handle disabled configuration requests #20358

Merged

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #19802.

Properly respect when clients do not have the workspace/configuration capability, a.k.a. when an editor cannot provide scoped settings on request from the LSP.

  • Fix one spot where we weren't checking for the capability before sending this request.
  • For enablePaths, fall back to the settings passed in the initialization options in more cases.
  • Respect the workspace/configuration capability in the test harness client.

See: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_configuration.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comments

@nayeemrmn nayeemrmn merged commit 12f6ad3 into denoland:main Sep 2, 2023
13 checks passed
@nayeemrmn nayeemrmn deleted the lsp-disabled-workspace-configuration branch September 3, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP enablePaths option not working in non-VSCode editor
2 participants