Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match TypeScript & JavaScript error colors #1793

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Match TypeScript & JavaScript error colors #1793

merged 2 commits into from
Feb 19, 2019

Conversation

bartlomieju
Copy link
Member

Closes #1714
zrzut ekranu 2019-02-16 o 14 06 35

@ry
Copy link
Member

ry commented Feb 16, 2019

It looks like the line number colors don’t match in your screen shot ?

@bartlomieju
Copy link
Member Author

Yikes, they certainly don't! Fixed
zrzut ekranu 2019-02-16 o 15 14 22

@bartlomieju
Copy link
Member Author

Same problem with AppVeyor as in #1774

ry
ry approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 27afbd1 into denoland:master Feb 19, 2019
@ry ry mentioned this pull request Feb 19, 2019
Closed
@bartlomieju bartlomieju deleted the match_error_colors branch May 27, 2019 18:06
@bartlomieju bartlomieju mentioned this pull request May 27, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @ry