-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emojis to permission prompts #1684
Conversation
I'll add emojis to other output strings too, but not too many. |
@daynin fixed! Thanks for a good advice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks -
Please use
It would be nice to make the text bold too... I think we could use
https://github.com/ogham/rust-ansi-term/blob/master/Cargo.toml
Or maybe it's easier just to write our own color module by porting this:
https://github.com/denoland/deno_std/blob/master/colors/mod.ts
@ry I think each emoji should say what is required, not just |
I disagree. The purpose of the emoji is just to distinguish an important message from other logging output - we should be consistent and minimal in applying these. This is not going to be one of these projects that splatters the screen with undiscerning graphics. |
@ry done! But after adding the |
@piscisaureus Please review for windows |
windows output visually looks like:
|
@piscisaureus are you in PowerShell or cmd? |
@sh7dm cmd. But I don't think that matters. |
|
revert the last commit to make it work on windows.... Use #[cfg(windows)] above the line. |
@piscisaureus please try again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nice work!
- Add deps to --info output (denoland#1720) - Add --allow-read (denoland#1689) - Add deno.isTTY() (denoland#1622) - Add emojis to permission prompts (denoland#1684) - Add basic WebAssembly support (denoland#1677) - Add `NO_COLOR` support https://no-color.org/ (denoland#1716) - Add color exceptions (denoland#1698) - Fix: do not load cache files when recompile flag is set (denoland#1695) - Upgrade V8 to 7.4.98 (denoland#1640)
- Add deps to --info output (#1720) - Add --allow-read (#1689) - Add deno.isTTY() (#1622) - Add emojis to permission prompts (#1684) - Add basic WebAssembly support (#1677) - Add `NO_COLOR` support https://no-color.org/ (#1716) - Add color exceptions (#1698) - Fix: do not load cache files when recompile flag is set (#1695) - Upgrade V8 to 7.4.98 (#1640)
Reason: #1651. I think it looks much better now