-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): update to TypeScript 4.5 #12410
Conversation
Updating to RC. Announced here: https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-rc/ The biggest change was the removal of the ESM support for Node12. This generally doesn't impact us, since we have our own resolution. It seems like the additional extensions (e.g. |
96fec4d
to
285b649
Compare
Updated to the released version. Want to create some tests for the new features that overlap with swc as well to make sure everything works fine as well as "enable" the other file types that are being introduced (e.g. |
@dsherret I think the tests will pass, but there is a bit of a catch-22 with dprint, in that dprint panics on the private field detection, which it is trying to do the ast parse, but can't see the |
@kitsonk update the version of the typescript plugin in |
@dsherret now dlint is updated as well, and there were some changes for the normal pass, but it seems now with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It seems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :D
There is a test for |
No, only assets which are not included by default do not go there, as per the comment: /// Contains static assets that are not preloaded in the compiler snapshot. And |
This updates TypeScript 4.5 beta.
Release announcement: https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/
Things we need to test/integrate:
type
on import namesmts
extensions