-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite "tools/" scripts in Deno #8223
Comments
for installing deno in CI script, would be using https://github.com/denolib/setup-deno alright, or rather do it manually? |
@crowlKats I think we should use |
If you just want to determine the latest Deno executable, download and unzip it, you can do that in a shell or cmd one-liner (or 3-liner, nicely formatted). v=$(curl -sSf https://github.com/denoland/deno/releases | grep -o \/denoland/deno/releases/download/.*/deno-x86_64-unknown-linux-gnu.zip | head -1 | cut -d/ -f6)
curl -Lo deno.zip https://github.com/denoland/deno/releases/download/$v/deno-x86_64-unknown-linux-gnu.zip
unzip deno.zip for /f "delims=/ tokens=6" %%v in ('"curl -sSf https://github.com/denoland/deno/releases | findstr \/denoland/deno/releases/download/.*/deno-x86_64-pc-windows-msvc.zip | findstr /n . | findstr ^1:"') do (
curl -Lo deno.zip https://github.com/denoland/deno/releases/download/%%v/deno-x86_64-pc-windows-msvc.zip
tar xf deno.zip
) Both // Note that |
Various utility scripts in
deno
repository, that are used during development and CI, are written in Python. Those are scripts intools/
directory. They are used for formatting, linting, parsing benchmarks output, etc.I think it would be beneficial to rewrite them to use Deno instead of Python. Doing so would completely remove dependency on Python (unsure about that,
rusty_v8
probably still needs it?) and close #5114 and #2893.Changes needed to resolve this issue:
deno
in CI script (.github/workflows/ci.yml
)tools/
:deno
deno
The easiest to rewrite would be
tools/format.py
andtools/lint.py
. Here are respective example scripts fromdeno_lint
repository which can be used as a basis for this refactor:The text was updated successfully, but these errors were encountered: