Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python3 #2893

Closed
ry opened this issue Sep 9, 2019 · 13 comments
Closed

Support python3 #2893

ry opened this issue Sep 9, 2019 · 13 comments

Comments

@ry
Copy link
Member

ry commented Sep 9, 2019

We are heavily dependent on V8, which in turn is heavily dependent on Chromium tooling, which does not support Python3 and has only recently begun conversion -
https://bugs.chromium.org/p/chromium/issues/detail?id=942720
https://bugs.chromium.org/p/v8/issues/detail?id=8594
nodejs/node#24512

@hayd
Copy link
Contributor

hayd commented Sep 10, 2019

I'm happy to do this, I think it'll be straightforward, but it's probably worth waiting for v8 support to be completed.

@cclauss
Copy link

cclauss commented Sep 10, 2019

it's probably worth waiting

Not! Python 3 was released 11 years ago and there are 113 days until Python 2 end of life. Please do work in parallel, not serial to be ready before yearend. It would be great if someone could get v8/v8#33 and v8/v8#34 pushed and landed upstream.

@hayd
Copy link
Contributor

hayd commented Sep 10, 2019

@cclauss I bet I can do the deno part of the port in under an hour, certainly less than a day. I've ported large modules to python 3... deno is very small. I suppose it would help to enumerate precisely which python v8 scripts need to be ported in order for deno to work, I can do that.

@cclauss
Copy link

cclauss commented Sep 10, 2019

Not a question of your skills. I have been impressed. It is just a question of putting lots of concentrated pressure on the few bottlenecks that are not ready so we create a compelling reason to act. We want to create the impression that the train is leaving the station without the laggards onboard.

@bmsdave
Copy link

bmsdave commented Oct 17, 2019

@kt3k
Copy link
Member

kt3k commented Dec 20, 2019

https://travis-ci.com/bmsdave/v8/builds/132539826
Does this mean v8 can be built with python 3?

@cclauss
Copy link

cclauss commented Dec 20, 2019

@bmsdave Can V8 be built with Python 3?

@hayd
Copy link
Contributor

hayd commented Dec 20, 2019

No: bmsdave/v8@845d137

@cclauss
Copy link

cclauss commented Dec 20, 2019

https://travis-ci.com/bmsdave/v8/builds Seems to be passing the lint steps. Where does the V8 build on Py3 break down?

@hayd
Copy link
Contributor

hayd commented Dec 20, 2019

The script it's running is true, the Travis build is not running any build/tests other than flake8...

@cclauss
Copy link

cclauss commented Dec 20, 2019

Exactly. So where can we see the build failing on Python 3?

@hayd
Copy link
Contributor

hayd commented Dec 20, 2019

Sorry I was answering (no) to @kt3k :

https://travis-ci.com/bmsdave/v8/builds/132539826
Does this mean v8 can be built with python 3?

It could be that the build works with just the syntax changes (but I would be surprised).

I think we need to compile and run with gm.py, see https://v8.dev/docs/test.

@kitsonk
Copy link
Contributor

kitsonk commented Nov 5, 2020

Closing in favour of #8223 (plus we have #7779).

@kitsonk kitsonk closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants