We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version: Deno 2.0.3
There is a regression in Deno 2.0.3 related to the Node Https Polyfill. The following worked fine in 2.0.2:
import {got} from 'npm:got'; await got.get('https://google.com').text();
After a bit of digging, it looks like it's this commit that caused the regression: afb33b3
I think this happens when the request method with 3 args is used.
request
The text was updated successfully, but these errors were encountered:
And here is pure Deno snippet that can be used in a regression test:
import {request} from 'node:https'; import type {IncomingMessage} from 'node:http'; const callback = (res: IncomingMessage) => { console.log(res.statusCode); }; const options = { hostname: 'www.google.com', method: 'GET', }; const req = request(new URL('https://goole.com'), options, callback); req.end();
Fails in 2.0.3 but works fine in 2.0.2
Sorry, something went wrong.
ext/node/polyfills/https.ts
46e5ed1
Revert "fix(ext/node): use primordials in `ext/node/polyfills/https.t…
a2dacc7
…s` (#26323)" (#26613) …s` (#26323)" This reverts commit afb33b3. Reverting because it caused a regression - #26612. Closes #26612.
Successfully merging a pull request may close this issue.
Version: Deno 2.0.3
There is a regression in Deno 2.0.3 related to the Node Https Polyfill. The following worked fine in 2.0.2:
After a bit of digging, it looks like it's this commit that caused the regression: afb33b3
I think this happens when the
request
method with 3 args is used.The text was updated successfully, but these errors were encountered: