Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin tokio version #26455

Closed
RonnyChan-okta opened this issue Oct 21, 2024 · 2 comments · Fixed by #26457
Closed

Unpin tokio version #26455

RonnyChan-okta opened this issue Oct 21, 2024 · 2 comments · Fixed by #26457

Comments

@RonnyChan-okta
Copy link
Contributor

The issue that caused the tokio version to be pinned is now fixed

#24958 (comment)

Could the tokio version be unpinned for deno crates?
@bartlomieju
Copy link
Member

Sure, PRs are welcome.

@RonnyChan-okta RonnyChan-okta mentioned this issue Oct 21, 2024
Merged
@RonnyChan-okta
Copy link
Contributor Author

RonnyChan-okta commented Oct 21, 2024 •
edited
Loading

I've made the PR but I will need to get confirmation from my manager before I'm able to sign the CLA. It may be faster/easier to make the change from your end as it's a one-line change.

bartlomieju pushed a commit that referenced this issue Oct 25, 2024
@RonnyChan-okta @bartlomieju
fix: unpin tokio version (#26457)
7c084f3 
Fixes #26455

Signed-off-by: Ronny Chan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unpin tokio version RonnyChan-okta/deno
2 participants
@bartlomieju @RonnyChan-okta