Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-Length header duplicated on Flash #18046

Closed
kitsonk opened this issue Mar 6, 2023 · 0 comments · Fixed by #18568
Closed

Content-Length header duplicated on Flash #18046

kitsonk opened this issue Mar 6, 2023 · 0 comments · Fixed by #18568
Labels
bug Something isn't working correctly

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Mar 6, 2023

When sending a Response with the Flash server, and the user provides a Content-Length header, the Flash server will add an additional Content-Length header with the content length as it calculated it, where as if the Content-Length is provided to the "native" stable server, it does not duplicate the header (I am not sure if it is overriding it or if it is just letting it pass through).

It feels like the Flash server should follow the behaviour of the native stable server.

Ref: oakserver/oak#587 (I will fix it in oak by simply omitting the content-length in all cases as the servers are actually better at handling this header now)

@bartlomieju bartlomieju added bug Something isn't working correctly flash labels Mar 6, 2023
levex pushed a commit that referenced this issue Apr 12, 2023
This commit changes implementation of "Deno.serve()" API to use
"Deno.serveHttp()" under the hood. This change will allow us to
remove the "flash" server implementation, bringing stability to the
"Deno.serve()" API.

"cli/tests/unit/flash_test.ts" was renamed to "serve_test.ts".

Closes #15574
Closes #15504
Closes #15646
Closes #15909
Closes #15911
Closes #16828
Closes #18046
Closes #15869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants