Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry auto discovery in LSP #10194

Closed
lucacasonato opened this issue Apr 15, 2021 · 0 comments · Fixed by #10813
Closed

Registry auto discovery in LSP #10194

lucacasonato opened this issue Apr 15, 2021 · 0 comments · Fixed by #10813
Assignees
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server

Comments

@lucacasonato
Copy link
Member

We should reintroduce the registry auto discovery we had in extension v2. Here is how it works:

When the LSP identifies an origin in a specifier for the first time it will try to fetch the well-known manifest for that origin. If a manifest is found, a message pops up asking the user if they want to enable import completions for that origin. If they press Yes the origin will be added to the deno.suggest.imports.hosts list and set to true. If they press no the origin will be added to that list, and set to false.

Example:
image

Auto discovery can be disabled with the deno.suggest.imports.autoDiscovery: false option. It is set to true by default.

@lucacasonato lucacasonato added feat new feature (which has been agreed to/accepted) lsp related to the language server labels Apr 15, 2021
@kitsonk kitsonk self-assigned this Apr 15, 2021
kitsonk added a commit to kitsonk/deno that referenced this issue Jun 1, 2021
kitsonk added a commit to kitsonk/deno that referenced this issue Jun 1, 2021
kitsonk added a commit that referenced this issue Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat new feature (which has been agreed to/accepted) lsp related to the language server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants