refactor: don't error when .env is not present (#21879)

Uses similar format to when the latest version of std is implicitly being used. Closes #21788
denoland · Jan 21, 2024 · b4990d1 · b4990d1
1 parent 983c745
commit b4990d1
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 9 deletions.
diff --git a/cli/args/mod.rs b/cli/args/mod.rs
@@ -725,7 +725,11 @@ impl CliOptions {
 
     if let Some(env_file_name) = &flags.env_file {
       if (from_filename(env_file_name)).is_err() {
-        bail!("Unable to load '{env_file_name}' environment variable file")
+        log::info!(
+          "{} The `--env` flag was used, but the dotenv file '{}' was not found.",
+          colors::yellow("Warning"),
+          env_file_name
+        );
       }
     }
 

diff --git a/cli/tests/integration/eval_tests.rs b/cli/tests/integration/eval_tests.rs
@@ -85,8 +85,5 @@ itest!(env_file {
 
 itest!(env_file_missing {
   args: "eval --env=missing console.log(Deno.env.get(\"ANOTHER_FOO\"))",
-  output_str: Some(
-    "error: Unable to load 'missing' environment variable file\n"
-  ),
-  exit_code: 1,
+  output: "eval/env_file_missing.out",
 });
diff --git a/cli/tests/integration/run_tests.rs b/cli/tests/integration/run_tests.rs
@@ -758,10 +758,7 @@ itest!(env_file {
 
 itest!(env_file_missing {
   args: "run --env=missing --allow-env run/env_file.ts",
-  output_str: Some(
-    "error: Unable to load 'missing' environment variable file\n"
-  ),
-  exit_code: 1,
+  output: "run/env_file_missing.out",
 });
 
 itest!(_091_use_define_for_class_fields {

diff --git a/cli/tests/testdata/eval/env_file_missing.out b/cli/tests/testdata/eval/env_file_missing.out
@@ -0,0 +1,2 @@
+Warning The `--env` flag was used, but the dotenv file 'missing' was not found.
+undefined
diff --git a/cli/tests/testdata/run/env_file_missing.out b/cli/tests/testdata/run/env_file_missing.out
@@ -0,0 +1,4 @@
+Warning The `--env` flag was used, but the dotenv file 'missing' was not found.
+undefined
+undefined
+undefined
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Warning The `--env` flag was used, but the dotenv file 'missing' was not found.
		undefined