fix(node): Add missing inspector/promises (#27491)

Add missing `inspector/promises` in node builtin module list, that causes types checking error.
denoland · Jan 9, 2025 · 1dd49e2 · 1dd49e2
1 parent 4d95005
commit 1dd49e2
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/cli/tsc/00_typescript.js b/cli/tsc/00_typescript.js
@@ -136063,6 +136063,7 @@ var unprefixedNodeCoreModuleList = [
   "https",
   "http2",
   "inspector",
+  "inspector/promises",
   "module",
   "net",
   "os",

diff --git a/ext/node/polyfill.rs b/ext/node/polyfill.rs
@@ -57,6 +57,7 @@ generate_builtin_node_module_lists! {
   "http2",
   "https",
   "inspector",
+  "inspector/promises",
   "module",
   "net",
   "os",

diff --git a/tests/integration/lsp_tests.rs b/tests/integration/lsp_tests.rs
@@ -8712,6 +8712,7 @@ fn lsp_completions_node_specifier() {
       "node:http2",
       "node:https",
       "node:inspector",
+      "node:inspector/promises",
       "node:module",
       "node:net",
       "node:os",

diff --git a/tests/unit_node/inspector_test.ts b/tests/unit_node/inspector_test.ts
@@ -1,5 +1,8 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 import inspector, { Session } from "node:inspector";
+import inspectorPromises, {
+  Session as SessionPromise,
+} from "node:inspector/promises";
 import { assertEquals } from "@std/assert/equals";
 
 Deno.test("[node/inspector] - importing inspector works", () => {
@@ -9,3 +12,11 @@ Deno.test("[node/inspector] - importing inspector works", () => {
 Deno.test("[node/inspector] - Session constructor should not throw", () => {
   new Session();
 });
+
+Deno.test("[node/inspector/promises] - importing inspector works", () => {
+  assertEquals(typeof inspectorPromises.open, "function");
+});
+
+Deno.test("[node/inspector/promises] - Session constructor should not throw", () => {
+  new SessionPromise();
+});