Do not crash the plugin packer if Assembly.GetTypes crashes

dennisreimann · Jun 21, 2024 · 05f3539 · 05f3539
1 parent 9d84ec4
commit 05f3539
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/BTCPayServer.PluginPacker/Program.cs b/BTCPayServer.PluginPacker/Program.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
 using System.IO.Compression;
@@ -109,9 +110,22 @@ private static async Task CreateShasums(string exec, string sha256dirs, string o
 
         private static Type[] GetAllExtensionTypesFromAssembly(Assembly assembly)
         {
-            return assembly.GetTypes().Where(type =>
+            return GetLoadableTypes(assembly).Where(type =>
                 typeof(IBTCPayServerPlugin).IsAssignableFrom(type) &&
                 !type.IsAbstract).ToArray();
         }
+        static Type[] GetLoadableTypes(Assembly assembly)
+        {
+            if (assembly == null)
+                throw new ArgumentNullException(nameof(assembly));
+            try
+            {
+                return assembly.GetTypes();
+            }
+            catch (ReflectionTypeLoadException e)
+            {
+                return e.Types.Where(t => t != null).ToArray();
+            }
+        }
     }
 }