Ensure that internal code is never exposed through InternalsVisibleTo

src/Reflectify/EmbeddedAttribute.cs

@@ -0,0 +1,26 @@
+#if !REFLECTIFY_COMPILE
+// <autogenerated />
+#pragma warning disable
+#endif
+
+#nullable disable
+
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+namespace Microsoft.CodeAnalysis;
+
+/// <summary>
+/// A special attribute recognized by Roslyn, that marks a type as "embedded", meaning it won't ever be visible from
+/// other assemblies.
+/// </summary>
+/// <remarks>
+/// Another source-only package compiled into the same assembly may declare this attribute too. Declaring it as
+/// <c>partial</c> lets both declarations merge into one type instead of colliding. For that to work, no part may
+/// carry a type-level attribute such as <c>[AttributeUsage]</c>, because attributes cannot be repeated across parts.
+/// Leaving it off is harmless: <c>AttributeTargets.All</c> is the default.
+/// </remarks>
+#pragma warning disable RCS1203, MA0010, CA1018 // Deliberately omitted so that duplicate declarations can merge, see above.
+internal sealed partial class EmbeddedAttribute : System.Attribute
+#pragma warning restore RCS1203, MA0010, CA1018
+{
+}

src/Reflectify/MemberInfoExtensions.cs

@@ -11,7 +11,13 @@
 
 namespace Reflectify;
 
+#if REFLECTIFY_COMPILE
+public static class MemberInfoExtensions
+#else
+[global::Microsoft.CodeAnalysis.Embedded]
+[global::System.Diagnostics.DebuggerNonUserCode]
 internal static class MemberInfoExtensions
+#endif
 {
     public static bool HasAttribute<TAttribute>(this MemberInfo member)
         where TAttribute : Attribute

src/Reflectify/MemberKind.cs

@@ -14,7 +14,12 @@ namespace Reflectify;
 /// Defines the kinds of members you want to get when querying for the fields and properties of a type.
 /// </summary>
 [Flags]
+#if REFLECTIFY_COMPILE
+public enum MemberKind
+#else
+[global::Microsoft.CodeAnalysis.Embedded]
 internal enum MemberKind
+#endif
 {
     None,
     Public = 1,
@@ -24,7 +29,13 @@ internal enum MemberKind
     Static = 16
 }
 
+#if REFLECTIFY_COMPILE
+public static class MemberKindExtensions
+#else
+[global::Microsoft.CodeAnalysis.Embedded]
+[global::System.Diagnostics.DebuggerNonUserCode]
 internal static class MemberKindExtensions
+#endif
 {
     public static BindingFlags ToBindingFlags(this MemberKind kind)
     {

src/Reflectify/ParameterInfoExtensions.cs

@@ -11,7 +11,13 @@
 
 namespace Reflectify;
 
+#if REFLECTIFY_COMPILE
+public static class ParameterInfoExtensions
+#else
+[global::Microsoft.CodeAnalysis.Embedded]
+[global::System.Diagnostics.DebuggerNonUserCode]
 internal static class ParameterInfoExtensions
+#endif
 {
     /// <summary>
     /// Returns <see langword="true" /> if the parameter is decorated with the specific <typeparamref name="TAttribute"/>,

src/Reflectify/PropertyInfoExtensions.cs

@@ -9,7 +9,13 @@
 
 namespace Reflectify;
 
+#if REFLECTIFY_COMPILE
+public static class PropertyInfoExtensions
+#else
+[global::Microsoft.CodeAnalysis.Embedded]
+[global::System.Diagnostics.DebuggerNonUserCode]
 internal static class PropertyInfoExtensions
+#endif
 {
     /// <summary>
     /// Returns <see langword="true" /> if the property is an indexer, or <see langword="false" /> otherwise.

src/Reflectify/Reflectify.csproj

@@ -8,14 +8,9 @@
         <NuSpecFile>.nuspec</NuSpecFile>
         <NuspecProperties>version=$(Version)</NuspecProperties>
         <DefineConstants>REFLECTIFY_COMPILE</DefineConstants>
+        <NoWarn>1591;1573</NoWarn>
     </PropertyGroup>
 
-  <ItemGroup Label="Internals visible to">
-    <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleToAttribute">
-      <_Parameter1>Reflectify.Specs</_Parameter1>
-    </AssemblyAttribute>
-  </ItemGroup>
-
   <PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
       <DocumentationFile>bin\Debug\Reflectify.xml</DocumentationFile>
     </PropertyGroup>

src/Reflectify/Reflector.cs

@@ -15,7 +15,13 @@ namespace Reflectify;
 /// <summary>
 /// Helper class to get all the public and internal fields and properties from a type.
 /// </summary>
+#if REFLECTIFY_COMPILE
+public sealed class Reflector(Type typeToReflect, MemberKind kind)
+#else
+[global::Microsoft.CodeAnalysis.Embedded]
+[global::System.Diagnostics.DebuggerNonUserCode]
 internal sealed class Reflector(Type typeToReflect, MemberKind kind)
+#endif
 {
     private readonly object lazyLoadingLock = new();
     private volatile PropertyInfo[] cachedProperties;
@@ -173,7 +179,7 @@ private static bool HasVisibility(MemberKind kind, FieldInfo field)
                ((kind & MemberKind.Internal) != MemberKind.None && (field.IsAssembly || field.IsFamilyOrAssembly));
     }
 
-    private class OrderedPropertyCollection
+    private sealed class OrderedPropertyCollection
     {
         private readonly Dictionary<string, PropertyKind> kindMap = new();
         private readonly List<(string Name, PropertyInfo Property)> propertiesWithName = new();

src/Reflectify/TypeExtensions.cs

@@ -9,7 +9,13 @@
 
 namespace Reflectify;
 
+#if REFLECTIFY_COMPILE
+public static class TypeExtensions
+#else
+[global::Microsoft.CodeAnalysis.Embedded]
+[global::System.Diagnostics.DebuggerNonUserCode]
 internal static class TypeExtensions
+#endif
 {
     /// <summary>
     /// If the type provided is a nullable type, gets the underlying type. Returns the type itself otherwise.

src/Reflectify/TypeMemberExtensions.cs

@@ -13,7 +13,13 @@
 
 namespace Reflectify;
 
+#if REFLECTIFY_COMPILE
+public static class TypeMemberExtensions
+#else
+[global::Microsoft.CodeAnalysis.Embedded]
+[global::System.Diagnostics.DebuggerNonUserCode]
 internal static class TypeMemberExtensions
+#endif
 {
     private static readonly ConcurrentDictionary<(Type Type, MemberKind Kind), Reflector> ReflectorCache = new();
 

src/Reflectify/TypeMetaDataExtensions.cs

@@ -14,7 +14,13 @@
 
 namespace Reflectify;
 
+#if REFLECTIFY_COMPILE
+public static class TypeMetaDataExtensions
+#else
+[global::Microsoft.CodeAnalysis.Embedded]
+[global::System.Diagnostics.DebuggerNonUserCode]
 internal static class TypeMetaDataExtensions
+#endif
 {
     /// <summary>
     /// Returns the name of the type without the generic backtick and the type arguments.