Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 11, 2025

  • Review existing GlobFiles implementation and understand the Matcher API
  • Add new GlobFiles overload that accepts params string[] globPatterns
  • Implement the new overload to add all patterns to the Matcher
  • Add comprehensive test cases for multiple glob patterns
  • Build and test the changes
  • Update API verification approved files
  • Verify all changes work correctly
  • Refactor single-pattern overload to use multi-pattern implementation
  • Update README with example of using multiple glob patterns
Original prompt

This section details on the original issue you should resolve

<issue_title>Extend GlobFiles with an array of strings to support multiple patterns</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #78


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Extend GlobFiles with an array of strings for multiple patterns Add GlobFiles overload to support multiple glob patterns Oct 11, 2025
Copilot AI requested a review from dennisdoomen October 11, 2025 15:27
Copilot finished work on behalf of dennisdoomen October 11, 2025 15:27
/// </remarks>
/// <param name="path">The base directory path to start the glob search from.</param>
/// <param name="globPattern">The glob pattern used to match file paths, e.g. **/*.md or dir/**/*</param>
public static ChainablePath[] GlobFiles(this ChainablePath path, string globPattern)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Rewrite the existing overload that takes a single pattern using the existing one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The single-pattern overload now delegates to the multi-pattern implementation, eliminating code duplication. All tests pass.

@dennisdoomen
Copy link
Owner

@copilot also update the readme with an example

Copy link
Contributor Author

Copilot AI commented Oct 11, 2025

@copilot also update the readme with an example

Done. Added an example showing both single and multiple pattern usage in the Globbing section (commit 144901a).

Copilot finished work on behalf of dennisdoomen October 11, 2025 15:45
@dennisdoomen dennisdoomen marked this pull request as ready for review October 11, 2025 15:52
@dennisdoomen dennisdoomen enabled auto-merge (squash) October 11, 2025 15:52
@dennisdoomen dennisdoomen added the enhancement New feature or request label Oct 11, 2025
@dennisdoomen dennisdoomen merged commit 0640a34 into main Oct 11, 2025
3 checks passed
@dennisdoomen dennisdoomen deleted the copilot/extend-globfiles-support branch October 11, 2025 15:54
@coveralls
Copy link

coveralls commented Oct 11, 2025

Pull Request Test Coverage Report for Build 18431471735

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 96.31%

Totals Coverage Status
Change from base Build 18431375497: -0.03%
Covered Lines: 187
Relevant Lines: 195

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend GlobFiles with an array of strings to support multiple patterns

3 participants