Conditionally compile with net.Dialer.KeepAlive option if go >= 1.3#94
Merged
Conversation
denisenkom
added a commit
that referenced
this pull request
Mar 29, 2015
Conditionally compile with net.Dialer.KeepAlive option if go >= 1.3
Owner
|
Thanks |
gabrielcorado
pushed a commit
to gravitational/go-mssqldb
that referenced
this pull request
Mar 24, 2023
…om#94) * Fixed denisenkom#93: servername was not supplied to TLS cfg A change in fd44003 moved the code for setting p.Host down in the parse function, resulting in an empty p.Host value at the time of the creation of p.TLSConfig. I extracted the TLS parsing into a separate function and moved the TLSConfig creation to the end of the parsing function. * Added extra test scenario with hostnameincertificate parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This make the library compile with go <= 1.2