return error of type 'mssql.Error' directly, because the Number in 'm… #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssql.Error' is useful for logic behavior.
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
=======================================
Coverage 68.72% 68.72%
=======================================
Files 23 23
Lines 5190 5190
=======================================
Hits 3567 3567
Misses 1410 1410
Partials 213 213
Continue to review full report at Codecov.
|
serbrech
reviewed
Oct 6, 2020
tds.go
Outdated
| case doneStruct: | ||
| if token.isError() { | ||
| return nil, fmt.Errorf("Login error: %s", token.getError()) |
There was a problem hiding this comment.
we could potentially use wrapping here :
return nil, fmt.Errorf("Login error: %w", token.getError())
that would keep the same current format (add the error string), but also provide the full underlying error when using errors.Is/As(...)
|
Can you add tests for this new feature. Also how do you make sure it is backward compatible? |
sdghchj
commented
Feb 23, 2021
tds.go
Outdated
| case doneStruct: | ||
| if token.isError() { | ||
| return nil, fmt.Errorf("Login error: %s", token.getError()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssql.Error' is useful for logic behavior.
fix the issue: #577