-
Couldn't load subscription status.
- Fork 10
Release v0.6.0 #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Release v0.6.0 #45
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9e3e45e
fix issues:
denis-tingaikin 724119f
fix ci
denis-tingaikin 123ab1f
rebase and add 'vars'
denis-tingaikin ebb64bf
fix tests and ci
denis-tingaikin adc22d3
fix self check
denis-tingaikin 0c76dad
add star-block like headers support
denis-tingaikin 8186b8e
add analysis.Analyzer
denis-tingaikin 7a4c9ab
add parallel execution support and plans
denis-tingaikin 167bd46
simplify readme
denis-tingaikin c7b2750
add fixes to be compatible with go tools
denis-tingaikin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this would include a fix so golangci-lint can automatically apply it. IIUC the Line value will point to the line after the comment as being the error location, so I think
Fix{Actual: []string{}, Expected: []string{""}},would be sufficient. Unfortunately my attempt to test it failed -isNewLineRequiredis returning false.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ldez Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golangci-lint can already apply fixes.
I think the current implementation based on
io.readeris hard to maintain and has some limitations.