Fix run on armv7#107
Merged
travisghansen merged 1 commit intodemocratic-csi:masterfrom Aug 9, 2021
c0va23:fix/run-on-armv7
Merged
Fix run on armv7#107travisghansen merged 1 commit intodemocratic-csi:masterfrom c0va23:fix/run-on-armv7
travisghansen merged 1 commit intodemocratic-csi:masterfrom
c0va23:fix/run-on-armv7
Conversation
Member
|
Oh wow good find! I’m not sure how this would have changed as I tested on a v7 install (although admittedly I generally just sanity test on arm64). Let’s move this just under the NODE_ENV line if you don’t mind. Then I’ll merge. This is great timing as I have a massive set of updates coming down the line. |
Contributor
Author
|
@travisghansen , I've moved line with fix. I hope I understood you correctly. Thanks for your quick response. I tested this fix on three architectures: amd64, arm64, armv7l. I am using democratic-csi + trunas (iscsi) as volume source for Drone CI. I created temporary images https://github.com/c0va23/democratic-csi/pkgs/container/democratic-csi, you can use them for testing. |
Member
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Recent images of
democratic-csicrash when launched on armv7l with error:This is a known nodejs 12 issue for armv7l : nodejs/node#37219
I suggest a temporary solution. The fix was tested on rpi4 with host OS ubuntu 20.04 (32bit).