sdk logging file size & rotation #3495
Merged
+106
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 56ecbc9c-0332-4296-8ada-9a290773fc30
💛 - Coveralls |
dorschw
reviewed
Aug 23, 2023
CHANGELOG.md
Outdated
Comment on lines
6
to
7
| * Fixed an issue with wrong recommendation for log level deprecated arguments in the sdk logger. | ||
| * Fixed an issue with wrong documentation for log level arguments in the sdk logger. |
| @@ -25,18 +26,42 @@ | |||
| DATE_FORMAT = "%Y-%m-%dT%H:%M:%S" | |||
|
|
|||
| DEPRECATED_PARAMETERS = { | |||
There was a problem hiding this comment.
were these underscored before deprecation?
There was a problem hiding this comment.
i'm just changing the new name, which use underscore and not hyphens
dorschw
reviewed
Aug 23, 2023
dorschw
reviewed
Aug 23, 2023
dorschw
reviewed
Aug 23, 2023
dorschw
approved these changes
Aug 23, 2023
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-8034
Description
sdk logging file size & rotation
Content PR - demisto/content#29144