Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileZip supports only AES encription #34428

Closed
wants to merge 22 commits into from
Closed

FileZip supports only AES encription #34428

wants to merge 22 commits into from

Conversation

MosheEichler
Copy link
Contributor

@MosheEichler MosheEichler commented May 19, 2024 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Added a comment to the troubleshooting that we support only AES encryption.

Must have

  • Tests
  • Documentation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 19, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CommonScripts/Scripts/ZipFile
   ZipFile.py76699%9, 11, 14–17, 19, 22–31, 33–34, 36–37, 39–40, 42–45, 47–48, 51–52, 54–55, 58–63, 65–66, 68, 71–72, 74–75, 78–81, 84–87, 89–91, 94, 96–97, 99–100, 103, 107–109, 111–113
TOTAL76699% 

Tests Skipped Failures Errors Time
1 0 💤 0 ❌ 1 🔥 1.959s ⏱️

@MosheEichler
Copy link
Contributor Author

closing as this is duplicate of this

@MosheEichler MosheEichler reopened this May 20, 2024
@MosheEichler MosheEichler mentioned this pull request May 20, 2024
Closed
@ShirleyDenkberg ShirleyDenkberg self-assigned this May 21, 2024
@ShirleyDenkberg
Copy link
Contributor

@MosheEichler Doc review completed.

@MosheEichler MosheEichler changed the title Fix zip file script with password FileZip supports only AES encription May 21, 2024
@MosheEichler
Copy link
Contributor Author

Will add the REAMDE note in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@thefrieddan1 thefrieddan1 Awaiting requested review from thefrieddan1

@DeanArbel DeanArbel Awaiting requested review from DeanArbel

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MosheEichler @ShirleyDenkberg