Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xpanse api updates #29339

Conversation

andrew-paloalto
Copy link
Contributor

@andrew-paloalto andrew-paloalto commented Aug 30, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-5829

Description

Several updates to the incoming mapper and field association. Also set a default classifier/mapper for the Cortex Xpanse integration.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Aug 30, 2023
@andrew-paloalto andrew-paloalto marked this pull request as draft August 30, 2023 20:38
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Aug 30, 2023
@content-bot content-bot changed the base branch from master to contrib/andrew-paloalto_xpanse-api-updates August 30, 2023 20:39
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @MichaelYochpaz will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-paloalto , these change and test and you should be good

@andrew-paloalto andrew-paloalto marked this pull request as ready for review August 31, 2023 15:12
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-paloalto , approved

@johnnywilkes
Copy link
Contributor

@melamedbn / @MichaelYochpaz , this is approved on Xpanse side and I don't think we cause the build errors. Please merge when possible.

@MichaelYochpaz MichaelYochpaz added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Aug 31, 2023
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6205314

Copy link
Contributor

@MichaelYochpaz MichaelYochpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, build passes without any issues :)
Just waiting for @melamedbn's approval.

@MichaelYochpaz MichaelYochpaz merged commit bb3e5e4 into demisto:contrib/andrew-paloalto_xpanse-api-updates Sep 5, 2023
@content-bot content-bot mentioned this pull request Sep 5, 2023
5 tasks
MichaelYochpaz added a commit that referenced this pull request Sep 6, 2023
* Xpanse api updates (#29339)

* improve classifier setup

* release notes

* release notes style

* remove field applicability

* Apply suggestions from code review

Co-authored-by: johnnywilkes <[email protected]>

---------

Co-authored-by: johnnywilkes <[email protected]>

* Fix missing dot

* Revert "Bump markdownlint from 0.26.2 to 0.30.0 (#28899)" (#29481)

This reverts commit e169068.

* fix using deprecated -vvv argument when calling the demisto sdk (#29470)

Co-authored-by: kobymeir <[email protected]>

* Update Docker Image To demisto/oci  (#29488)

* Updated Metadata Of Pack OracleCloudInfrastructure

* Added release notes to pack OracleCloudInfrastructure

* Packs/OracleCloudInfrastructure/Integrations/OracleCloudInfrastructureEventCollector/OracleCloudInfrastructureEventCollector.yml Docker image update

* Update Docker Image To demisto/taxii2  (#29490)

* Updated Metadata Of Pack FeedUnit42v2

* Added release notes to pack FeedUnit42v2

* Packs/FeedUnit42v2/Integrations/FeedUnit42v2/FeedUnit42v2.yml Docker image update

* Update Docker Image To demisto/netmiko  (#29501)

* Updated Metadata Of Pack Netmiko

* Added release notes to pack Netmiko

* Packs/Netmiko/Integrations/Netmiko/Netmiko.yml Docker image update

* Deprecating block url generic (#29453)

* Release Notes

* enhance

* RN

* validation fix

* fix

* Bump pack from version CommonPlaybooks to 2.5.0.

* fix

* fix

* fix

---------

Co-authored-by: Content Bot <[email protected]>

* Fix dnstwistTest TPB (#29455)

* Change domain argument in task 6

* Update task 6 name

* Test different domain argument due to timeout

* Fix Get Original Email - Microsoft Graph Mail - test TPB (#29467)

* Update MessageID and SHA256 values in the TPB

* Update secrets-ignore

* New features for emails (#29400)

* New features for emails (#28916)

* New features for emails

* Fix validations

* Fix lint and test

* Increase coverage and fix validation

* Increase test coverage

* Manual report condition

* Request changes

* Fixes request changes

* Fix last fetch

* Skip event with last fetch time

* Remove sensitive data

* Change args from simple to complex format

* Update notification endpoint

* Minor fixes

* Fix layout field

* Fix condition for manual alerts

* Update docker

* Add button to get campaign result and fix scan info command output

* Update release notes

* fix Rn

* fix rn

* fix rn

* remove an empty line

* add a "." for validation to pass

* one more period

---------

Co-authored-by: Christian Gutierrez <[email protected]>
Co-authored-by: Yehuda <[email protected]>

* Security scans (#25915)

* added as a new build flow

* reverted gitlab

* changed ref to master

---------

Co-authored-by: Andrew Scott <[email protected]>
Co-authored-by: johnnywilkes <[email protected]>
Co-authored-by: Michael Yochpaz <[email protected]>
Co-authored-by: Koby Meir <[email protected]>
Co-authored-by: kobymeir <[email protected]>
Co-authored-by: ArikDay <[email protected]>
Co-authored-by: Content Bot <[email protected]>
Co-authored-by: samuelFain <[email protected]>
Co-authored-by: Christian Gutierrez <[email protected]>
Co-authored-by: Yehuda <[email protected]>
Co-authored-by: Yuval Cohen <[email protected]>
moishce pushed a commit that referenced this pull request Sep 14, 2023
* Xpanse api updates (#29339)

* improve classifier setup

* release notes

* release notes style

* remove field applicability

* Apply suggestions from code review

Co-authored-by: johnnywilkes <[email protected]>

---------

Co-authored-by: johnnywilkes <[email protected]>

* Fix missing dot

* Revert "Bump markdownlint from 0.26.2 to 0.30.0 (#28899)" (#29481)

This reverts commit e169068.

* fix using deprecated -vvv argument when calling the demisto sdk (#29470)

Co-authored-by: kobymeir <[email protected]>

* Update Docker Image To demisto/oci  (#29488)

* Updated Metadata Of Pack OracleCloudInfrastructure

* Added release notes to pack OracleCloudInfrastructure

* Packs/OracleCloudInfrastructure/Integrations/OracleCloudInfrastructureEventCollector/OracleCloudInfrastructureEventCollector.yml Docker image update

* Update Docker Image To demisto/taxii2  (#29490)

* Updated Metadata Of Pack FeedUnit42v2

* Added release notes to pack FeedUnit42v2

* Packs/FeedUnit42v2/Integrations/FeedUnit42v2/FeedUnit42v2.yml Docker image update

* Update Docker Image To demisto/netmiko  (#29501)

* Updated Metadata Of Pack Netmiko

* Added release notes to pack Netmiko

* Packs/Netmiko/Integrations/Netmiko/Netmiko.yml Docker image update

* Deprecating block url generic (#29453)

* Release Notes

* enhance

* RN

* validation fix

* fix

* Bump pack from version CommonPlaybooks to 2.5.0.

* fix

* fix

* fix

---------

Co-authored-by: Content Bot <[email protected]>

* Fix dnstwistTest TPB (#29455)

* Change domain argument in task 6

* Update task 6 name

* Test different domain argument due to timeout

* Fix Get Original Email - Microsoft Graph Mail - test TPB (#29467)

* Update MessageID and SHA256 values in the TPB

* Update secrets-ignore

* New features for emails (#29400)

* New features for emails (#28916)

* New features for emails

* Fix validations

* Fix lint and test

* Increase coverage and fix validation

* Increase test coverage

* Manual report condition

* Request changes

* Fixes request changes

* Fix last fetch

* Skip event with last fetch time

* Remove sensitive data

* Change args from simple to complex format

* Update notification endpoint

* Minor fixes

* Fix layout field

* Fix condition for manual alerts

* Update docker

* Add button to get campaign result and fix scan info command output

* Update release notes

* fix Rn

* fix rn

* fix rn

* remove an empty line

* add a "." for validation to pass

* one more period

---------

Co-authored-by: Christian Gutierrez <[email protected]>
Co-authored-by: Yehuda <[email protected]>

* Security scans (#25915)

* added as a new build flow

* reverted gitlab

* changed ref to master

---------

Co-authored-by: Andrew Scott <[email protected]>
Co-authored-by: johnnywilkes <[email protected]>
Co-authored-by: Michael Yochpaz <[email protected]>
Co-authored-by: Koby Meir <[email protected]>
Co-authored-by: kobymeir <[email protected]>
Co-authored-by: ArikDay <[email protected]>
Co-authored-by: Content Bot <[email protected]>
Co-authored-by: samuelFain <[email protected]>
Co-authored-by: Christian Gutierrez <[email protected]>
Co-authored-by: Yehuda <[email protected]>
Co-authored-by: Yuval Cohen <[email protected]>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* Xpanse api updates (demisto#29339)

* improve classifier setup

* release notes

* release notes style

* remove field applicability

* Apply suggestions from code review

Co-authored-by: johnnywilkes <[email protected]>

---------

Co-authored-by: johnnywilkes <[email protected]>

* Fix missing dot

* Revert "Bump markdownlint from 0.26.2 to 0.30.0 (demisto#28899)" (demisto#29481)

This reverts commit e169068.

* fix using deprecated -vvv argument when calling the demisto sdk (demisto#29470)

Co-authored-by: kobymeir <[email protected]>

* Update Docker Image To demisto/oci  (demisto#29488)

* Updated Metadata Of Pack OracleCloudInfrastructure

* Added release notes to pack OracleCloudInfrastructure

* Packs/OracleCloudInfrastructure/Integrations/OracleCloudInfrastructureEventCollector/OracleCloudInfrastructureEventCollector.yml Docker image update

* Update Docker Image To demisto/taxii2  (demisto#29490)

* Updated Metadata Of Pack FeedUnit42v2

* Added release notes to pack FeedUnit42v2

* Packs/FeedUnit42v2/Integrations/FeedUnit42v2/FeedUnit42v2.yml Docker image update

* Update Docker Image To demisto/netmiko  (demisto#29501)

* Updated Metadata Of Pack Netmiko

* Added release notes to pack Netmiko

* Packs/Netmiko/Integrations/Netmiko/Netmiko.yml Docker image update

* Deprecating block url generic (demisto#29453)

* Release Notes

* enhance

* RN

* validation fix

* fix

* Bump pack from version CommonPlaybooks to 2.5.0.

* fix

* fix

* fix

---------

Co-authored-by: Content Bot <[email protected]>

* Fix dnstwistTest TPB (demisto#29455)

* Change domain argument in task 6

* Update task 6 name

* Test different domain argument due to timeout

* Fix Get Original Email - Microsoft Graph Mail - test TPB (demisto#29467)

* Update MessageID and SHA256 values in the TPB

* Update secrets-ignore

* New features for emails (demisto#29400)

* New features for emails (demisto#28916)

* New features for emails

* Fix validations

* Fix lint and test

* Increase coverage and fix validation

* Increase test coverage

* Manual report condition

* Request changes

* Fixes request changes

* Fix last fetch

* Skip event with last fetch time

* Remove sensitive data

* Change args from simple to complex format

* Update notification endpoint

* Minor fixes

* Fix layout field

* Fix condition for manual alerts

* Update docker

* Add button to get campaign result and fix scan info command output

* Update release notes

* fix Rn

* fix rn

* fix rn

* remove an empty line

* add a "." for validation to pass

* one more period

---------

Co-authored-by: Christian Gutierrez <[email protected]>
Co-authored-by: Yehuda <[email protected]>

* Security scans (demisto#25915)

* added as a new build flow

* reverted gitlab

* changed ref to master

---------

Co-authored-by: Andrew Scott <[email protected]>
Co-authored-by: johnnywilkes <[email protected]>
Co-authored-by: Michael Yochpaz <[email protected]>
Co-authored-by: Koby Meir <[email protected]>
Co-authored-by: kobymeir <[email protected]>
Co-authored-by: ArikDay <[email protected]>
Co-authored-by: Content Bot <[email protected]>
Co-authored-by: samuelFain <[email protected]>
Co-authored-by: Christian Gutierrez <[email protected]>
Co-authored-by: Yehuda <[email protected]>
Co-authored-by: Yuval Cohen <[email protected]>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* Xpanse api updates (#29339)

* improve classifier setup

* release notes

* release notes style

* remove field applicability

* Apply suggestions from code review

Co-authored-by: johnnywilkes <[email protected]>

---------

Co-authored-by: johnnywilkes <[email protected]>

* Fix missing dot

* Revert "Bump markdownlint from 0.26.2 to 0.30.0 (#28899)" (#29481)

This reverts commit fc25003.

* fix using deprecated -vvv argument when calling the demisto sdk (#29470)

Co-authored-by: kobymeir <[email protected]>

* Update Docker Image To demisto/oci  (#29488)

* Updated Metadata Of Pack OracleCloudInfrastructure

* Added release notes to pack OracleCloudInfrastructure

* Packs/OracleCloudInfrastructure/Integrations/OracleCloudInfrastructureEventCollector/OracleCloudInfrastructureEventCollector.yml Docker image update

* Update Docker Image To demisto/taxii2  (#29490)

* Updated Metadata Of Pack FeedUnit42v2

* Added release notes to pack FeedUnit42v2

* Packs/FeedUnit42v2/Integrations/FeedUnit42v2/FeedUnit42v2.yml Docker image update

* Update Docker Image To demisto/netmiko  (#29501)

* Updated Metadata Of Pack Netmiko

* Added release notes to pack Netmiko

* Packs/Netmiko/Integrations/Netmiko/Netmiko.yml Docker image update

* Deprecating block url generic (#29453)

* Release Notes

* enhance

* RN

* validation fix

* fix

* Bump pack from version CommonPlaybooks to 2.5.0.

* fix

* fix

* fix

---------

Co-authored-by: Content Bot <[email protected]>

* Fix dnstwistTest TPB (#29455)

* Change domain argument in task 6

* Update task 6 name

* Test different domain argument due to timeout

* Fix Get Original Email - Microsoft Graph Mail - test TPB (#29467)

* Update MessageID and SHA256 values in the TPB

* Update secrets-ignore

* New features for emails (#29400)

* New features for emails (#28916)

* New features for emails

* Fix validations

* Fix lint and test

* Increase coverage and fix validation

* Increase test coverage

* Manual report condition

* Request changes

* Fixes request changes

* Fix last fetch

* Skip event with last fetch time

* Remove sensitive data

* Change args from simple to complex format

* Update notification endpoint

* Minor fixes

* Fix layout field

* Fix condition for manual alerts

* Update docker

* Add button to get campaign result and fix scan info command output

* Update release notes

* fix Rn

* fix rn

* fix rn

* remove an empty line

* add a "." for validation to pass

* one more period

---------

Co-authored-by: Christian Gutierrez <[email protected]>
Co-authored-by: Yehuda <[email protected]>

* Security scans (#25915)

* added as a new build flow

* reverted gitlab

* changed ref to master

---------

Co-authored-by: Andrew Scott <[email protected]>
Co-authored-by: johnnywilkes <[email protected]>
Co-authored-by: Michael Yochpaz <[email protected]>
Co-authored-by: Koby Meir <[email protected]>
Co-authored-by: kobymeir <[email protected]>
Co-authored-by: ArikDay <[email protected]>
Co-authored-by: Content Bot <[email protected]>
Co-authored-by: samuelFain <[email protected]>
Co-authored-by: Christian Gutierrez <[email protected]>
Co-authored-by: Yehuda <[email protected]>
Co-authored-by: Yuval Cohen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants