Xpanse api updates #29339
Merged
Xpanse api updates #29339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content-bot
added
Community
Contribution Form Filled
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/andrew-paloalto_xpanse-api-updates
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @MichaelYochpaz will know the proposed changes are ready to be reviewed. |
johnnywilkes
suggested changes
Aug 31, 2023
There was a problem hiding this comment.
@andrew-paloalto , these change and test and you should be good
Co-authored-by: johnnywilkes <[email protected]>
johnnywilkes
approved these changes
Aug 31, 2023
|
@melamedbn / @MichaelYochpaz , this is approved on Xpanse side and I don't think we cause the build errors. Please merge when possible. |
MichaelYochpaz
added
the
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6205314 |
MichaelYochpaz
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Looks good, build passes without any issues :)
Just waiting for @melamedbn's approval.
MichaelYochpaz
merged commit bb3e5e4
into
demisto:contrib/andrew-paloalto_xpanse-api-updates
MichaelYochpaz
added a commit
that referenced
this pull request
Sep 6, 2023
* Xpanse api updates (#29339) * improve classifier setup * release notes * release notes style * remove field applicability * Apply suggestions from code review Co-authored-by: johnnywilkes <[email protected]> --------- Co-authored-by: johnnywilkes <[email protected]> * Fix missing dot * Revert "Bump markdownlint from 0.26.2 to 0.30.0 (#28899)" (#29481) This reverts commit e169068. * fix using deprecated -vvv argument when calling the demisto sdk (#29470) Co-authored-by: kobymeir <[email protected]> * Update Docker Image To demisto/oci (#29488) * Updated Metadata Of Pack OracleCloudInfrastructure * Added release notes to pack OracleCloudInfrastructure * Packs/OracleCloudInfrastructure/Integrations/OracleCloudInfrastructureEventCollector/OracleCloudInfrastructureEventCollector.yml Docker image update * Update Docker Image To demisto/taxii2 (#29490) * Updated Metadata Of Pack FeedUnit42v2 * Added release notes to pack FeedUnit42v2 * Packs/FeedUnit42v2/Integrations/FeedUnit42v2/FeedUnit42v2.yml Docker image update * Update Docker Image To demisto/netmiko (#29501) * Updated Metadata Of Pack Netmiko * Added release notes to pack Netmiko * Packs/Netmiko/Integrations/Netmiko/Netmiko.yml Docker image update * Deprecating block url generic (#29453) * Release Notes * enhance * RN * validation fix * fix * Bump pack from version CommonPlaybooks to 2.5.0. * fix * fix * fix --------- Co-authored-by: Content Bot <[email protected]> * Fix dnstwistTest TPB (#29455) * Change domain argument in task 6 * Update task 6 name * Test different domain argument due to timeout * Fix Get Original Email - Microsoft Graph Mail - test TPB (#29467) * Update MessageID and SHA256 values in the TPB * Update secrets-ignore * New features for emails (#29400) * New features for emails (#28916) * New features for emails * Fix validations * Fix lint and test * Increase coverage and fix validation * Increase test coverage * Manual report condition * Request changes * Fixes request changes * Fix last fetch * Skip event with last fetch time * Remove sensitive data * Change args from simple to complex format * Update notification endpoint * Minor fixes * Fix layout field * Fix condition for manual alerts * Update docker * Add button to get campaign result and fix scan info command output * Update release notes * fix Rn * fix rn * fix rn * remove an empty line * add a "." for validation to pass * one more period --------- Co-authored-by: Christian Gutierrez <[email protected]> Co-authored-by: Yehuda <[email protected]> * Security scans (#25915) * added as a new build flow * reverted gitlab * changed ref to master --------- Co-authored-by: Andrew Scott <[email protected]> Co-authored-by: johnnywilkes <[email protected]> Co-authored-by: Michael Yochpaz <[email protected]> Co-authored-by: Koby Meir <[email protected]> Co-authored-by: kobymeir <[email protected]> Co-authored-by: ArikDay <[email protected]> Co-authored-by: Content Bot <[email protected]> Co-authored-by: samuelFain <[email protected]> Co-authored-by: Christian Gutierrez <[email protected]> Co-authored-by: Yehuda <[email protected]> Co-authored-by: Yuval Cohen <[email protected]>
moishce
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Xpanse api updates (#29339) * improve classifier setup * release notes * release notes style * remove field applicability * Apply suggestions from code review Co-authored-by: johnnywilkes <[email protected]> --------- Co-authored-by: johnnywilkes <[email protected]> * Fix missing dot * Revert "Bump markdownlint from 0.26.2 to 0.30.0 (#28899)" (#29481) This reverts commit e169068. * fix using deprecated -vvv argument when calling the demisto sdk (#29470) Co-authored-by: kobymeir <[email protected]> * Update Docker Image To demisto/oci (#29488) * Updated Metadata Of Pack OracleCloudInfrastructure * Added release notes to pack OracleCloudInfrastructure * Packs/OracleCloudInfrastructure/Integrations/OracleCloudInfrastructureEventCollector/OracleCloudInfrastructureEventCollector.yml Docker image update * Update Docker Image To demisto/taxii2 (#29490) * Updated Metadata Of Pack FeedUnit42v2 * Added release notes to pack FeedUnit42v2 * Packs/FeedUnit42v2/Integrations/FeedUnit42v2/FeedUnit42v2.yml Docker image update * Update Docker Image To demisto/netmiko (#29501) * Updated Metadata Of Pack Netmiko * Added release notes to pack Netmiko * Packs/Netmiko/Integrations/Netmiko/Netmiko.yml Docker image update * Deprecating block url generic (#29453) * Release Notes * enhance * RN * validation fix * fix * Bump pack from version CommonPlaybooks to 2.5.0. * fix * fix * fix --------- Co-authored-by: Content Bot <[email protected]> * Fix dnstwistTest TPB (#29455) * Change domain argument in task 6 * Update task 6 name * Test different domain argument due to timeout * Fix Get Original Email - Microsoft Graph Mail - test TPB (#29467) * Update MessageID and SHA256 values in the TPB * Update secrets-ignore * New features for emails (#29400) * New features for emails (#28916) * New features for emails * Fix validations * Fix lint and test * Increase coverage and fix validation * Increase test coverage * Manual report condition * Request changes * Fixes request changes * Fix last fetch * Skip event with last fetch time * Remove sensitive data * Change args from simple to complex format * Update notification endpoint * Minor fixes * Fix layout field * Fix condition for manual alerts * Update docker * Add button to get campaign result and fix scan info command output * Update release notes * fix Rn * fix rn * fix rn * remove an empty line * add a "." for validation to pass * one more period --------- Co-authored-by: Christian Gutierrez <[email protected]> Co-authored-by: Yehuda <[email protected]> * Security scans (#25915) * added as a new build flow * reverted gitlab * changed ref to master --------- Co-authored-by: Andrew Scott <[email protected]> Co-authored-by: johnnywilkes <[email protected]> Co-authored-by: Michael Yochpaz <[email protected]> Co-authored-by: Koby Meir <[email protected]> Co-authored-by: kobymeir <[email protected]> Co-authored-by: ArikDay <[email protected]> Co-authored-by: Content Bot <[email protected]> Co-authored-by: samuelFain <[email protected]> Co-authored-by: Christian Gutierrez <[email protected]> Co-authored-by: Yehuda <[email protected]> Co-authored-by: Yuval Cohen <[email protected]>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* Xpanse api updates (demisto#29339) * improve classifier setup * release notes * release notes style * remove field applicability * Apply suggestions from code review Co-authored-by: johnnywilkes <[email protected]> --------- Co-authored-by: johnnywilkes <[email protected]> * Fix missing dot * Revert "Bump markdownlint from 0.26.2 to 0.30.0 (demisto#28899)" (demisto#29481) This reverts commit e169068. * fix using deprecated -vvv argument when calling the demisto sdk (demisto#29470) Co-authored-by: kobymeir <[email protected]> * Update Docker Image To demisto/oci (demisto#29488) * Updated Metadata Of Pack OracleCloudInfrastructure * Added release notes to pack OracleCloudInfrastructure * Packs/OracleCloudInfrastructure/Integrations/OracleCloudInfrastructureEventCollector/OracleCloudInfrastructureEventCollector.yml Docker image update * Update Docker Image To demisto/taxii2 (demisto#29490) * Updated Metadata Of Pack FeedUnit42v2 * Added release notes to pack FeedUnit42v2 * Packs/FeedUnit42v2/Integrations/FeedUnit42v2/FeedUnit42v2.yml Docker image update * Update Docker Image To demisto/netmiko (demisto#29501) * Updated Metadata Of Pack Netmiko * Added release notes to pack Netmiko * Packs/Netmiko/Integrations/Netmiko/Netmiko.yml Docker image update * Deprecating block url generic (demisto#29453) * Release Notes * enhance * RN * validation fix * fix * Bump pack from version CommonPlaybooks to 2.5.0. * fix * fix * fix --------- Co-authored-by: Content Bot <[email protected]> * Fix dnstwistTest TPB (demisto#29455) * Change domain argument in task 6 * Update task 6 name * Test different domain argument due to timeout * Fix Get Original Email - Microsoft Graph Mail - test TPB (demisto#29467) * Update MessageID and SHA256 values in the TPB * Update secrets-ignore * New features for emails (demisto#29400) * New features for emails (demisto#28916) * New features for emails * Fix validations * Fix lint and test * Increase coverage and fix validation * Increase test coverage * Manual report condition * Request changes * Fixes request changes * Fix last fetch * Skip event with last fetch time * Remove sensitive data * Change args from simple to complex format * Update notification endpoint * Minor fixes * Fix layout field * Fix condition for manual alerts * Update docker * Add button to get campaign result and fix scan info command output * Update release notes * fix Rn * fix rn * fix rn * remove an empty line * add a "." for validation to pass * one more period --------- Co-authored-by: Christian Gutierrez <[email protected]> Co-authored-by: Yehuda <[email protected]> * Security scans (demisto#25915) * added as a new build flow * reverted gitlab * changed ref to master --------- Co-authored-by: Andrew Scott <[email protected]> Co-authored-by: johnnywilkes <[email protected]> Co-authored-by: Michael Yochpaz <[email protected]> Co-authored-by: Koby Meir <[email protected]> Co-authored-by: kobymeir <[email protected]> Co-authored-by: ArikDay <[email protected]> Co-authored-by: Content Bot <[email protected]> Co-authored-by: samuelFain <[email protected]> Co-authored-by: Christian Gutierrez <[email protected]> Co-authored-by: Yehuda <[email protected]> Co-authored-by: Yuval Cohen <[email protected]>
tkatzir
pushed a commit
that referenced
this pull request
Dec 20, 2023
* Xpanse api updates (#29339) * improve classifier setup * release notes * release notes style * remove field applicability * Apply suggestions from code review Co-authored-by: johnnywilkes <[email protected]> --------- Co-authored-by: johnnywilkes <[email protected]> * Fix missing dot * Revert "Bump markdownlint from 0.26.2 to 0.30.0 (#28899)" (#29481) This reverts commit fc25003. * fix using deprecated -vvv argument when calling the demisto sdk (#29470) Co-authored-by: kobymeir <[email protected]> * Update Docker Image To demisto/oci (#29488) * Updated Metadata Of Pack OracleCloudInfrastructure * Added release notes to pack OracleCloudInfrastructure * Packs/OracleCloudInfrastructure/Integrations/OracleCloudInfrastructureEventCollector/OracleCloudInfrastructureEventCollector.yml Docker image update * Update Docker Image To demisto/taxii2 (#29490) * Updated Metadata Of Pack FeedUnit42v2 * Added release notes to pack FeedUnit42v2 * Packs/FeedUnit42v2/Integrations/FeedUnit42v2/FeedUnit42v2.yml Docker image update * Update Docker Image To demisto/netmiko (#29501) * Updated Metadata Of Pack Netmiko * Added release notes to pack Netmiko * Packs/Netmiko/Integrations/Netmiko/Netmiko.yml Docker image update * Deprecating block url generic (#29453) * Release Notes * enhance * RN * validation fix * fix * Bump pack from version CommonPlaybooks to 2.5.0. * fix * fix * fix --------- Co-authored-by: Content Bot <[email protected]> * Fix dnstwistTest TPB (#29455) * Change domain argument in task 6 * Update task 6 name * Test different domain argument due to timeout * Fix Get Original Email - Microsoft Graph Mail - test TPB (#29467) * Update MessageID and SHA256 values in the TPB * Update secrets-ignore * New features for emails (#29400) * New features for emails (#28916) * New features for emails * Fix validations * Fix lint and test * Increase coverage and fix validation * Increase test coverage * Manual report condition * Request changes * Fixes request changes * Fix last fetch * Skip event with last fetch time * Remove sensitive data * Change args from simple to complex format * Update notification endpoint * Minor fixes * Fix layout field * Fix condition for manual alerts * Update docker * Add button to get campaign result and fix scan info command output * Update release notes * fix Rn * fix rn * fix rn * remove an empty line * add a "." for validation to pass * one more period --------- Co-authored-by: Christian Gutierrez <[email protected]> Co-authored-by: Yehuda <[email protected]> * Security scans (#25915) * added as a new build flow * reverted gitlab * changed ref to master --------- Co-authored-by: Andrew Scott <[email protected]> Co-authored-by: johnnywilkes <[email protected]> Co-authored-by: Michael Yochpaz <[email protected]> Co-authored-by: Koby Meir <[email protected]> Co-authored-by: kobymeir <[email protected]> Co-authored-by: ArikDay <[email protected]> Co-authored-by: Content Bot <[email protected]> Co-authored-by: samuelFain <[email protected]> Co-authored-by: Christian Gutierrez <[email protected]> Co-authored-by: Yehuda <[email protected]> Co-authored-by: Yuval Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
https://jira-dc.paloaltonetworks.com/browse/EXPANDR-5829
Description
Several updates to the incoming mapper and field association. Also set a default classifier/mapper for the Cortex Xpanse integration.
Must have