Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk logging file size & rotation #29144

Merged
merged 3 commits into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ parameters:
references:
environment: &environment
environment:
# A flag for the demisto_client to not cache it's last response in order to avoid memory leaks
# A flag for the demisto_client to not cache its last response in order to avoid memory leaks.
DONT_CACHE_LAST_RESPONSE: "true"
DEMISTO_SDK_LOG_FILE_SIZE: 1073741824 # 1GB
ARTIFACT_BUILD_NUM: << pipeline.parameters.artifact_build_num >>
CONTRIB_BRANCH: << pipeline.parameters.contrib_branch >>
CONTRIB_PACK_NAME: << pipeline.parameters.contrib_pack_name >>
Expand Down
8 changes: 4 additions & 4 deletions .gitlab/ci/.gitlab-ci.global.yml
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
- *get_last_upload_commit
- *install_ssh_keys
- section_start "Build Parameters"
- set | grep -E "^NIGHTLY=|^INSTANCE_TESTS=|^SERVER_BRANCH_NAME=|^ARTIFACT_BUILD_NUM=|^DEMISTO_SDK_NIGHTLY=|^TIME_TO_LIVE=|^CONTRIB_BRANCH=|^FORCE_PACK_UPLOAD=|^PACKS_TO_UPLOAD=|^BUCKET_UPLOAD=|^STORAGE_BASE_PATH=|^OVERRIDE_ALL_PACKS=|^GCS_MARKET_BUCKET=|^GCS_MARKET_V2_BUCKET=|^GCS_MARKET_XPANSE_BUCKET=|^SLACK_CHANNEL=|^NVM_DIR=|^NODE_VERSION=|^PATH=|^ARTIFACTS_FOLDER=|^ENV_RESULTS_PATH=|^LAST_UPLOAD_COMMIT="
- set | grep -E "^NIGHTLY=|^INSTANCE_TESTS=|^SERVER_BRANCH_NAME=|^ARTIFACT_BUILD_NUM=|^DEMISTO_SDK_NIGHTLY=|^TIME_TO_LIVE=|^CONTRIB_BRANCH=|^FORCE_PACK_UPLOAD=|^PACKS_TO_UPLOAD=|^BUCKET_UPLOAD=|^STORAGE_BASE_PATH=|^OVERRIDE_ALL_PACKS=|^GCS_MARKET_BUCKET=|^GCS_MARKET_V2_BUCKET=|^GCS_MARKET_XPANSE_BUCKET=|^SLACK_CHANNEL=|^NVM_DIR=|^NODE_VERSION=|^PATH=|^ARTIFACTS_FOLDER=|^ENV_RESULTS_PATH=|^LAST_UPLOAD_COMMIT=|^DEMISTO_SDK_LOG_FILE_SIZE=|^DEMISTO_SDK_LOG_FILE_COUNT=|^DEMISTO_SDK_LOG_FILE_PATH=|^DEMISTO_SDK_LOG_NO_COLORS=|^DEMISTO_SDK_LOG_NOTIFY_PATH="
- neo4j-admin dbms set-initial-password contentgraph
- neo4j start
- python --version
Expand Down Expand Up @@ -273,14 +273,14 @@
fi
if [ -n "$SHOULD_LINT_ALL" ]; then
echo -e "----------\nLinting all because:\n${SHOULD_LINT_ALL}\n----------"
demisto-sdk lint -vvv -p 10 -a --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -dt 120 --time-measurements-dir $ARTIFACTS_FOLDER --docker-image ${DOCKER}
demisto-sdk lint -p 10 -a --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -dt 120 --time-measurements-dir $ARTIFACTS_FOLDER --docker-image ${DOCKER}
fi
if [[ -n $BUCKET_UPLOAD ]]; then
demisto-sdk lint -vvv -p 8 -g --no-mypy --prev-ver $LAST_UPLOAD_COMMIT -v --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -cdam --docker-image ${DOCKER}
demisto-sdk lint --console_log_threshold DEBUG -p 8 -g --no-mypy --prev-ver $LAST_UPLOAD_COMMIT -v --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -cdam --docker-image ${DOCKER}
else
if [[ "$CI_COMMIT_BRANCH" != "master" ]]; then
# skip running `lint -g` on master
demisto-sdk lint -p 8 -g -vvv --test-xml ./unit-tests --log-path ./artifacts --failure-report ./artifacts --coverage-report $ARTIFACTS_FOLDER/coverage_report -cdam --docker-image ${DOCKER}
demisto-sdk lint --console_log_threshold DEBUG -p 8 -g --test-xml ./unit-tests --log-path ./artifacts --failure-report ./artifacts --coverage-report $ARTIFACTS_FOLDER/coverage_report -cdam --docker-image ${DOCKER}
fi
fi

Expand Down
2 changes: 1 addition & 1 deletion .gitlab/ci/.gitlab-ci.sdk-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ demisto-sdk-nightly:run-commands-against-instance:
- demisto-sdk validate -i Packs/HelloWorld/
- section_end "Run Validate"
- section_start "Run Lint" --collapsed
- demisto-sdk lint -i Packs/HelloWorld/ -vvv
- demisto-sdk lint --console_log_threshold DEBUG -i Packs/HelloWorld/
- section_end "Run Lint"
- *change-file-ids
- *upload-entities-to-cortex-xsoar
Expand Down
2 changes: 1 addition & 1 deletion .gitlab/ci/.gitlab-ci.test-native-candidate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ test-native-candidate:run-lint-with-native-candidate:
touch $ARTIFACTS_FOLDER/native_candidate_image.txt
echo "$NATIVE_CANDIDATE_IMAGE" >> $ARTIFACTS_FOLDER/native_candidate_image.txt

demisto-sdk lint -vvv -p 10 -a --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -dt 120 --time-measurements-dir $ARTIFACTS_FOLDER --docker-image native:target --docker-image-target "$NATIVE_CANDIDATE_IMAGE"
demisto-sdk lint --console_log_threshold DEBUG -p 10 -a --test-xml ./unit-tests --log-path $ARTIFACTS_FOLDER --failure-report $ARTIFACTS_FOLDER --coverage-report $ARTIFACTS_FOLDER/coverage_report -dt 120 --time-measurements-dir $ARTIFACTS_FOLDER --docker-image native:target --docker-image-target "$NATIVE_CANDIDATE_IMAGE"
if [[ -f $ARTIFACTS_FOLDER/coverage_report/.coverage ]]; then
demisto-sdk coverage-analyze -i $ARTIFACTS_FOLDER/coverage_report/.coverage --report-dir $ARTIFACTS_FOLDER/coverage_report --report-type all --allowed-coverage-degradation-percentage 100
fi
Expand Down