Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes related to usernames in Account Enrichment #29024

Merged
merged 18 commits into from
Aug 23, 2023

Conversation

idovandijk
Copy link
Contributor

@idovandijk idovandijk commented Aug 16, 2023

Status

BLOCKED - https://jira-hq.paloaltonetworks.local/browse/CIAC-7906
Ready

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-27200

Description

  • Fixed account enrichment username input to support domain\user format too
  • Fixed the XDR task in the account enrichment playbook to accept both username and domain\username
  • Added XDR to the account enrichment test in conf.json
  • Updated the account enrichment test playbook to be from 6.8.0 (lowest supported version)
  • Updated playbook docs
  • Updated account enrichment playbook image

- Fixed account enrichment username input to support domain\user format too
- Fixed the XDR task in the account enrichment playbook to accept both username and domain\username
- Added playbooks and formatted them
- Added XDR to the account enrichment test in conf.json
- Updated the account enrichment test playbook to be from 6.8.0 (lowest supported version)
- Generated docs
- Updated accont enrichment playbook image
@idovandijk
Copy link
Contributor Author

@AdiPeret I made a number of fixes here. PR is ready except for RN, and currently blocked by XDR issue because I added XDR to our account enrichment test playbook.
Once that issue is resolved, I will update this PR with RN.

@idovandijk idovandijk added the release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process label Aug 20, 2023
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonPlaybooks pack version was bumped to 2.3.94.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CortexXDR pack version was bumped to 5.0.10.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@idovandijk
Copy link
Contributor Author

@AdiPeret PR is ready
@ShirleyDenkberg can you please review the RN? Thanks

@ShirleyDenkberg
Copy link
Contributor

@AdiPeret @michalgold @ostolero Doc review completed.

@idovandijk idovandijk merged commit be6b4e1 into master Aug 23, 2023
@idovandijk idovandijk deleted the account-enrichment-username-fixes branch August 23, 2023 08:11
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* - Fixed playbook input from malware to account enrichment
- Fixed account enrichment username input to support domain\user format too
- Fixed the XDR task in the account enrichment playbook to accept both username and domain\username
- Added playbooks and formatted them
- Added XDR to the account enrichment test in conf.json
- Updated the account enrichment test playbook to be from 6.8.0 (lowest supported version)
- Generated docs
- Updated accont enrichment playbook image

* Added RNs for both packs

* Bump pack from version CommonPlaybooks to 2.3.94.

* Fixed description

* description fixes

* Bump pack from version CortexXDR to 5.0.10.

* Updated description for username input

* Updated playbook readme with the new playbook input description

* Fixed a small typo

* Update Packs/CortexXDR/ReleaseNotes/5_0_10.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/CommonPlaybooks/ReleaseNotes/2_3_95.md

Co-authored-by: ShirleyDenkberg <[email protected]>

---------

Co-authored-by: Content Bot <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants