Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cortex XDR] Improve Error Message #28932

Merged
merged 29 commits into from
Aug 24, 2023
Merged

Conversation

shmuel44
Copy link
Contributor

@shmuel44 shmuel44 commented Aug 13, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

instated to raise an error when the XDR Identity Threat Module in the XDR instance is disabled,
now we return a warning to the war room,
(to prevent from the playbooks to fail)

  • xdr-list-risky-users
  • xdr-list-risky-hosts

Must have

  • Tests
  • Documentation

@shmuel44 shmuel44 self-assigned this Aug 13, 2023
@shmuel44 shmuel44 requested a review from dorschw August 13, 2023 15:17
@shmuel44 shmuel44 marked this pull request as ready for review August 13, 2023 15:17
@shmuel44 shmuel44 requested a review from dansterenson as a code owner August 13, 2023 15:17
Packs/Core/ReleaseNotes/2_0_6.md Outdated Show resolved Hide resolved
Packs/Core/ReleaseNotes/2_0_6.md Outdated Show resolved Hide resolved
Packs/Core/ReleaseNotes/2_0_9.md Outdated Show resolved Hide resolved
Packs/Core/ReleaseNotes/2_0_9.md Outdated Show resolved Hide resolved
Packs/CortexXDR/ReleaseNotes/5_0_11.md Outdated Show resolved Hide resolved
@shmuel44 shmuel44 requested a review from dorschw August 23, 2023 15:53
Packs/Core/ReleaseNotes/2_0_9.md Outdated Show resolved Hide resolved
Packs/CortexXDR/ReleaseNotes/5_0_11.md Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@dansterenson @dorschw Doc review completed.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CortexXDR pack version was bumped to 5.1.1.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@shmuel44 shmuel44 merged commit 5e7eb9a into master Aug 24, 2023
@shmuel44 shmuel44 deleted the sk_xdr_error_message_xsup_27092 branch August 24, 2023 12:02
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* added error message

* RN

* Apply suggestions from code review

Co-authored-by: dorschw <[email protected]>

* Update 5_0_8.md

* fix cr

* return warning

* return warning

* revert

* revert

* revert

* test

* UT

* RN

* RN

* Update Packs/Core/ReleaseNotes/2_0_9.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update Packs/CortexXDR/ReleaseNotes/5_0_11.md

Co-authored-by: ShirleyDenkberg <[email protected]>

* Update 5_0_11.md

* Update Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py

Co-authored-by: dorschw <[email protected]>

* Update Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py

Co-authored-by: dorschw <[email protected]>

* cr

* copy

* Bump pack from version CortexXDR to 5.1.1.

---------

Co-authored-by: dorschw <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: Content Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants