Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FireEye ETP Event Collector #28863

Merged
merged 23 commits into from
Aug 23, 2023
Merged

Add FireEye ETP Event Collector #28863

merged 23 commits into from
Aug 23, 2023

Conversation

JasBeilin
Copy link
Contributor

@JasBeilin JasBeilin commented Aug 9, 2023 •
edited
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-5922

Description

Adding new event collector to allow fetch of alerts, email-trace and activity-log from users.

Must have

  • Tests
  • Documentation

@JasBeilin JasBeilin self-assigned this Aug 9, 2023
@JasBeilin JasBeilin changed the title WIP Add FireEye ETP Event Collector Aug 9, 2023
ShirleyDenkberg
ShirleyDenkberg reviewed Aug 9, 2023
View reviewed changes
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector.yml Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector.yml Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector_description.md Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector_description.md Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector_description.md Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/README.md Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/README.md Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/README.md Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/README.md Outdated Show resolved Hide resolved
Packs/FireEyeETP/ReleaseNotes/1_3_0.md Outdated Show resolved Hide resolved
@ShirleyDenkberg ShirleyDenkberg self-assigned this Aug 9, 2023
@ShirleyDenkberg
Copy link
Contributor

@yuvalbenshalom Doc review completed.

yuvalbenshalom
yuvalbenshalom requested changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. see my comments.

general comment, please check if passing **args is really needed. in general I prefer to avoid it.

Packs/FireEyeETP/pack_metadata.json Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector.py Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector.py Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector.py Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector.py Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector.py Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector_test.py Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector_test.py Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector.py Outdated Show resolved Hide resolved
Packs/FireEyeETP/Integrations/FireEyeETPEventCollector/FireEyeETPEventCollector.py Outdated Show resolved Hide resolved
@JasBeilin
Copy link
Contributor Author

Some changes post Demo-

  1. API Key display name change
  2. Permission in Description are now joined
  3. Handling a wrong credential error.
  4. mapping changes
  5. sensitive data will not be deleted but replaced with "hidden data"
  6. better explanation of the outbound param affects
  7. better get-command warning of use.

@JasBeilin JasBeilin merged commit de4cc24 into master Aug 23, 2023
@JasBeilin JasBeilin deleted the fireeyeetp_event_collector branch August 23, 2023 12:14
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
@JasBeilin @ShirleyDenkberg @xsoar-bot
Add FireEye ETP Event Collector (demisto#28863)
2e9c921 
* WIP

* fix pre commit

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <[email protected]>

* fix linting

* fix linting

* fix linting

* CR and demo fixes

* pre-commit fixes

* fix tests + change of status field

* revert pep8 changes in other integration

* test file fix

* lint fix

* fix linting

* modeling rules fix

* lint fix

---------

Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@yuvalbenshalom yuvalbenshalom yuvalbenshalom approved these changes

Assignees

@ShirleyDenkberg ShirleyDenkberg

@JasBeilin JasBeilin

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasBeilin @ShirleyDenkberg @yuvalbenshalom