new github workflow for new label #28279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub_workflow_partner
ShacharKidor
requested changes
Aug 7, 2023
Utils/github_workflow_scripts/check_if_partner_approved_label.py
Outdated
Show resolved
Hide resolved
Utils/github_workflow_scripts/check_if_partner_approved_label.py
Outdated
Show resolved
Hide resolved
Utils/github_workflow_scripts/check_if_partner_approved_label.py
Outdated
Show resolved
Hide resolved
Utils/github_workflow_scripts/check_if_partner_approved_label.py
Outdated
Show resolved
Hide resolved
Utils/github_workflow_scripts/check_if_partner_approved_label.py
Outdated
Show resolved
Hide resolved
Utils/github_workflow_scripts/check_if_partner_approved_label.py
Outdated
Show resolved
Hide resolved
Utils/github_workflow_scripts/check_if_partner_approved_label.py
Outdated
Show resolved
Hide resolved
# Conflicts: # Utils/github_workflow_scripts/utils.py
…thub_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py
ShacharKidor
requested changes
Aug 21, 2023
There was a problem hiding this comment.
Great Work!
I added a comment about the condition in the github action - please have a look.
Last things:
- Please add a description to the PR body explaining what we did here.
- Please open a new PR from a forked repo to check that handle_new_external_pr work as expected without any errors.
Utils/github_workflow_scripts/check_if_partner_approved_label_exists.py
Outdated
Show resolved
Hide resolved
Utils/github_workflow_scripts/check_if_partner_approved_label_exists.py
Outdated
Show resolved
Hide resolved
|
@ShacharKidor |
# Conflicts: # Utils/github_workflow_scripts/utils.py
ShacharKidor
approved these changes
Aug 22, 2023
# Conflicts: # Utils/github_workflow_scripts/utils.py
…thub_workflow_partner
# Conflicts: # Utils/github_workflow_scripts/utils.py
# Conflicts: # Utils/github_workflow_scripts/utils.py
# Conflicts: # Utils/github_workflow_scripts/utils.py
5 tasks
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Fix all comments after demo * Fix all comments after demo * Fix all comments after demo * fix comments * Fix all comments after demo * Fix all comments after demo * Fix all comments after demo * Fix all comments after demo * moving funciton to utils * Merge branch 'master' into github_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py * Merge branch 'master' into github_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py * Merge branch 'master' into github_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py * Merge branch 'master' into github_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py * Merge branch 'master' into github_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py
israelpoli
pushed a commit
that referenced
this pull request
May 15, 2024
* new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * new github workflow for new label * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Fix all comments after demo * Fix all comments after demo * Fix all comments after demo * fix comments * Fix all comments after demo * Fix all comments after demo * Fix all comments after demo * Fix all comments after demo * moving funciton to utils * Merge branch 'master' into github_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py * Merge branch 'master' into github_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py * Merge branch 'master' into github_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py * Merge branch 'master' into github_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py * Merge branch 'master' into github_workflow_partner # Conflicts: # Utils/github_workflow_scripts/utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
When a community contribution is done for partner pack - need to get partner to review and approve.
A new label was added to the content repository and a new github workflow that will fail if the "partner-approved" label was not added to the PR.
If the contribution form verified that this is a partner - the label will be added automatically.
If not, reviewer will need to add this label to pass the new workflow
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have