-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core api file delete: reverting deleting files from context data #27960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalpalo
approved these changes
Sep 6, 2023
moishce
pushed a commit
that referenced
this pull request
Sep 14, 2023
) * Fix a bug in core-api-file-delete * fixed if * server fix * server fixes * server add on * removing delete context * removing type chat * adding RL * fixing condition * fixing validation errors * fixing validation * guy manor fix after checks * Update CoreRESTAPI.yml --------- Co-authored-by: dorschw <[email protected]>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
…isto#27960) * Fix a bug in core-api-file-delete * fixed if * server fix * server fixes * server add on * removing delete context * removing type chat * adding RL * fixing condition * fixing validation errors * fixing validation * guy manor fix after checks * Update CoreRESTAPI.yml --------- Co-authored-by: dorschw <[email protected]>
tkatzir
pushed a commit
that referenced
this pull request
Dec 20, 2023
) * Fix a bug in core-api-file-delete * fixed if * server fix * server fixes * server add on * removing delete context * removing type chat * adding RL * fixing condition * fixing validation errors * fixing validation * guy manor fix after checks * Update CoreRESTAPI.yml --------- Co-authored-by: dorschw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
relates: link to the issue
Description
Fixed a bug in 'core-api-file-delete' where all the files were deleted from context data instead of the selected one.
Also fixed some 'if' errors.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?