Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump SmartListing version #1360

Closed
fredZen opened this issue Jan 23, 2018 · 4 comments
Closed

Bump SmartListing version #1360

fredZen opened this issue Jan 23, 2018 · 4 comments
Assignees
@fredZen @mmagn
Labels
tech

Comments

@fredZen
Copy link
Contributor

fredZen commented Jan 23, 2018

No description provided.

@fredZen fredZen added the tech label Jan 23, 2018
fredZen added a commit that referenced this issue Jan 23, 2018
@fredZen
[#1360] Upgrade SmartListing to fork of 1.2.1
a4aba56
@fredZen
Copy link
Contributor Author

fredZen commented Jan 23, 2018

Le commit comporte deux contournements à enlever quand le problème correspondant aura été corrigé upstream:

a4aba56#diff-8b7db4d5cc4b8f6dc8feb7030baa2478R77 est un contournement de Sology/smart_listing#126

a4aba56#diff-20ab6677da23c9aebc3acf6d7aa19fc6R32 est un contournement de Sology/smart_listing#134

fredZen added a commit that referenced this issue Jan 24, 2018
@fredZen
[#1360] Upgrade SmartListing to fork of 1.2.1
f729bdf
@fredZen
Copy link
Contributor Author

fredZen commented Jan 24, 2018

cas restant potentiellement à traiter (utilisent smart_listing, pas de test qui casse, mais c’est peut-être bien parce-qu’il manque le test)

  • ./app/controllers/admin/gestionnaires_controller.rb: @gestionnaires = smart_listing_create :gestionnaires,
  • ./app/controllers/admin/procedures_controller.rb: @procedures = smart_listing_create :procedures,
  • ./app/controllers/admin/procedures_controller.rb: @procedures = smart_listing_create :procedures,
  • ./app/controllers/admin/procedures_controller.rb: @procedures = smart_listing_create :procedures,
  • ./app/controllers/admin/accompagnateurs_controller.rb: @accompagnateurs_assign = smart_listing_create :accompagnateurs_assign,
  • ./app/controllers/admin/accompagnateurs_controller.rb: @accompagnateurs_not_assign = smart_listing_create :accompagnateurs_not_assign,

@gregoirenovel
Copy link
Contributor

Je suis à moitié convaincu par ce que je vais proposer : est-ce qu'on veut pas attendre les erreurs Sentry avant de s'attaquer à ces cas ?

fredZen added a commit that referenced this issue Jan 25, 2018
@fredZen
[#1360] Upgrade SmartListing to fork of 1.2.1
df60bca
fredZen added a commit that referenced this issue Jan 25, 2018
@fredZen
[#1360] Upgrade SmartListing to fork of 1.2.1
184dd86
fredZen added a commit that referenced this issue Jan 25, 2018
@fredZen
[#1360] Upgrade SmartListing to fork of 1.2.1
4d22aec
@fredZen fredZen mentioned this issue Jan 25, 2018
Merged
fredZen added a commit that referenced this issue Jan 25, 2018
@fredZen
[#1360] Upgrade SmartListing to fork of 1.2.1
15581a8
fredZen added a commit that referenced this issue Jan 25, 2018
@fredZen
[#1360] Upgrade SmartListing to fork of 1.2.1
60499b2
fredZen added a commit that referenced this issue Jan 25, 2018
@fredZen
[#1360] Upgrade SmartListing to fork of 1.2.1
506a505
fredZen added a commit that referenced this issue Jan 25, 2018
@fredZen
Merge pull request #1366 from betagouv/fix_1360-upgrade_smart_listing
1c8ae50 
[#1360] Upgrade SmartListing to fork of 1.2.1
@gregoirenovel gregoirenovel reopened this Jan 25, 2018
LeSim pushed a commit that referenced this issue Jan 29, 2018
Revert "[#1360] Upgrade SmartListing to fork of 1.2.1"
691b126 
This reverts commit 506a505.
LeSim pushed a commit that referenced this issue Jan 29, 2018
Merge pull request #1373 from betagouv/fix_pagination
5a56fe0 
Revert "[#1360] Upgrade SmartListing to fork of 1.2.1"
@gregoirenovel
Copy link
Contributor

Fixed by #1592

tchak pushed a commit to tchak/tps that referenced this issue Aug 9, 2018
@fredZen @tchak
[demarches-simplifiees#1360] Upgrade SmartListing to fork of 1.2.1
3fad4fa
tchak pushed a commit to tchak/tps that referenced this issue Aug 9, 2018
@tchak
Revert "[demarches-simplifiees#1360] Upgrade SmartListing to fork of …
7375388 
…1.2.1"

This reverts commit 506a505.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredZen fredZen

@mmagn mmagn

Labels
tech
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fredZen @mmagn @gregoirenovel