Skip to content

feat: use released VersionMark from NuGet in CI release process and lint scripts#69

Merged
Malcolmnixon merged 1 commit intomainfrom
copilot/update-versionmark-ci-release-process
Apr 11, 2026
Merged

feat: use released VersionMark from NuGet in CI release process and lint scripts#69
Malcolmnixon merged 1 commit intomainfrom
copilot/update-versionmark-ci-release-process

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

Pull Request

Description

Previously, the VersionMark repo avoided installing its own released package to prevent name collisions. Now that dotnet versionmark (local tool) and the globally-installed versionmark (CI-built) occupy distinct paths, the released version can be used throughout the build pipeline — with the CI-built version reserved exclusively for integration tests.

.config/dotnet-tools.json

  • Added demaconsulting.versionmark 1.2.0 so dotnet versionmark runs the released NuGet version

lint.sh / lint.bat

  • Added dotnet versionmark --lint between reqstream and reviewmark lint steps, making both scripts binary-identical to the TemplateDotNetTool template

build.yamlbuild-docs job

  • Removed "Download packages artifact" and "Install VersionMark from package" steps
  • Replaced all bare versionmark invocations with dotnet versionmark (capture, validate, publish)

build.yamlquality-checks / build jobs

  • Removed stale comments stating VersionMark capture was unavailable

The integration-test job is unchanged — it remains the only job that installs and runs the CI-built tool globally.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.VersionMark --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No source or test code changes — CI/lint infrastructure only.

…int scripts

Agent-Logs-Url: https://github.com/demaconsulting/VersionMark/sessions/d93969e4-ec6b-44b2-a1fe-3a717b31fdcf

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon Malcolmnixon marked this pull request as ready for review April 11, 2026 23:36
Copilot AI review requested due to automatic review settings April 11, 2026 23:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s CI/lint infrastructure to use the released VersionMark .NET local tool (dotnet versionmark) across linting and documentation-generation workflows, reserving the CI-built global versionmark tool for integration testing.

Changes:

  • Added demaconsulting.versionmark (v1.2.0) to the local tool manifest so dotnet versionmark runs the released NuGet tool.
  • Updated lint.sh and lint.bat to run dotnet versionmark --lint between ReqStream and ReviewMark lint steps.
  • Simplified build-docs in .github/workflows/build.yaml by removing package-artifact download/global tool install, and switched VersionMark invocations to dotnet versionmark.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
lint.sh Adds dotnet versionmark --lint to the lint pipeline after tool restore.
lint.bat Adds dotnet versionmark --lint to the Windows lint pipeline after tool restore.
.github/workflows/build.yaml Removes global tool installation from build-docs and uses dotnet versionmark for capture/validate/publish; removes stale comments.
.config/dotnet-tools.json Pins the released VersionMark tool in the local tool manifest (v1.2.0).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants