Skip to content

Remove shell overrides from build workflow#89

Merged
Malcolmnixon merged 4 commits intomainfrom
copilot/simplify-build-shell-usage
Jan 27, 2026
Merged

Remove shell overrides from build workflow#89
Malcolmnixon merged 4 commits intomainfrom
copilot/simplify-build-shell-usage

Conversation

Copy link
Contributor

Copilot AI commented Jan 27, 2026

Pull Request

Description

The build-docs job specified shell: pwsh in 4 steps. All shell overrides have been removed by replacing PowerShell-specific commands with cross-platform bash equivalents.

Removed all shell: pwsh overrides from:

  • Generate CodeQL Quality Report with SarifMark (uses only dotnet command)
  • Display CodeQL Quality Report (replaced Get-Content with cat)
  • Generate Code Quality Report with SonarMark (replaced $env:SONAR_TOKEN with $SONAR_TOKEN)
  • Display SonarCloud Quality Report (replaced Get-Content with cat)

By using bash commands instead of PowerShell-specific syntax, the workflow is now more cross-platform compatible and no longer requires explicit shell overrides.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Addresses build cleanup issue regarding shell usage simplification.

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint '**/*.{yml,yaml}'

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

YAML configuration change only. No functional changes - the workflow continues to work as before but with simplified, cross-platform commands.

Original prompt

This section details on the original issue you should resolve

<issue_title>[Feature]: Build cleanup</issue_title>
<issue_description>### Problem Statement

The build.yaml file overrides the shell to 'pwsh' in some cases.

Proposed Solution

Review shell usage and simplify if possible.

Alternatives Considered

No response

Usage Examples

Benefits

Simpler build.

Priority

Low - Nice to have

Willingness to Contribute

Yes, I can submit a pull request

Additional Context

No response

Checklist

  • I have searched existing issues to ensure this is not a duplicate
  • I have provided a clear description of the feature
  • I have explained why this feature would be useful</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Review and simplify shell usage in build.yaml Remove redundant shell overrides in build workflow Jan 27, 2026
Copilot AI requested a review from Malcolmnixon January 27, 2026 20:45
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title Remove redundant shell overrides in build workflow Simplify shell overrides in build workflow Jan 27, 2026
Copilot AI requested a review from Malcolmnixon January 27, 2026 20:50
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title Simplify shell overrides in build workflow Remove shell overrides from build workflow Jan 27, 2026
Copilot AI requested a review from Malcolmnixon January 27, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Build cleanup

2 participants