Replace Assert.IsTrue(Contains) with Assert.Contains per MSTEST0037

[Copilot]

Pull Request

Description

Eight MSTEST0037 code smells across IOTests.cs and TestResultsLibraryTests.cs where Assert.IsTrue(x.Contains(...)) should use the idiomatic Assert.Contains(...).

- Assert.IsTrue(content.Contains("TestRun"), "Expected TRX XML to contain 'TestRun'");
+ Assert.Contains("TestRun", content, "Expected TRX XML to contain 'TestRun'");

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

• Code builds successfully: dotnet build --configuration Release
• All unit tests pass: dotnet test --configuration Release
• Code produces zero warnings

Code Quality

• Code formatting is correct: dotnet format --verify-no-changes
• New code has appropriate XML documentation comments
• Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

• All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

• Added unit tests for new functionality
• Updated existing tests if behavior changed
• All tests follow the AAA (Arrange, Act, Assert) pattern
• Test coverage is maintained or improved

Documentation

• Updated README.md (if applicable)
• Updated ARCHITECTURE.md (if applicable)
• Added code examples for new features (if applicable)
• Updated requirements.yaml (if applicable)

Additional Notes

Mechanical change only — matches the Assert.Contains(substring, value) pattern already used elsewhere in the test suite.

[Copilot]

Pull request overview

This PR addresses MSTEST0037 analyzer findings in the test suite by replacing Assert.IsTrue(x.Contains(...)) patterns with the idiomatic MSTest Assert.Contains(...) calls for substring checks.

Changes:

• Updated TRX serialization assertions in IOTests and TestResultsLibraryTests to use Assert.Contains(...).
• Updated JUnit serialization assertions in the same tests to use Assert.Contains(...).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
test/DemaConsulting.TestResults.Tests/TestResultsLibraryTests.cs	Replaces Assert.IsTrue(content.Contains(...)) with Assert.Contains(...) in library end-to-end serialization tests.
test/DemaConsulting.TestResults.Tests/IO/IOTests.cs	Replaces Assert.IsTrue(content.Contains(...)) with Assert.Contains(...) in IO subsystem serialization tests.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.