-
Notifications
You must be signed in to change notification settings - Fork 0
Sync AGENTS.md, agent files, standards, and lint scripts from TemplateDotNetLibrary #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,73 @@ | ||
| --- | ||
| name: code-review | ||
| description: Assists in performing formal file reviews. | ||
| tools: [read, search, edit, execute, github, web, agent] | ||
| description: Agent for performing formal reviews | ||
| user-invocable: true | ||
| --- | ||
|
|
||
| # Code Review Agent | ||
|
|
||
| Execute comprehensive code reviews with emphasis on structured compliance verification and file review status | ||
| requirements. | ||
| This agent runs the formal review based on the review-set it's told to perform. | ||
|
|
||
| ## Reporting | ||
| # Formal Review Steps | ||
|
|
||
| Create a report using the filename pattern `AGENT_REPORT_code_review_[review-set].md` | ||
| (e.g., `AGENT_REPORT_code_review_auth-module.md`) to document review criteria, identified issues, and recommendations | ||
| for the specific review-set. | ||
|
|
||
| ## Review Steps | ||
| Formal reviews are a quality enforcement mechanism, and as such MUST be performed using the following four steps: | ||
|
|
||
| 1. Download the | ||
| <https://github.com/demaconsulting/ContinuousCompliance/raw/refs/heads/main/docs/review-template/review-template.md> | ||
| to get the checklist to fill in | ||
| 2. Use `dotnet reviewmark --elaborate [review-set]` to get the files to review | ||
| 3. Review the files all together | ||
| 4. Populate the checklist with the findings to make the report | ||
|
|
||
| ## Hand-off to Other Agents | ||
|
|
||
| Only attempt to apply review fixes if requested. | ||
| 4. Populate the checklist with the findings to `.agent-logs/reviews/review-report-{review-set}.md` of the project. | ||
|
|
||
| - If code quality, logic, or structural issues need fixing, call the @software-developer agent | ||
| - If test coverage gaps or quality issues are identified, call the @test-developer agent | ||
| - If documentation accuracy or completeness issues are found, call the @technical-writer agent | ||
| - If quality gate verification is needed after fixes, call the @code-quality agent | ||
| - If requirements traceability issues are discovered, call the @requirements agent | ||
| # Don't Do These Things | ||
|
|
||
| ## Don't Do These Things | ||
|
|
||
| - **Never modify code during review** (document findings only, delegate fixes) | ||
| - **Never modify code during review** (document findings only) | ||
| - **Never skip applicable checklist items** (comprehensive review required) | ||
| - **Never approve reviews with unresolved critical findings** | ||
| - **Never bypass review status requirements** for compliance | ||
| - **Never conduct reviews without proper documentation** | ||
| - **Never ignore security or compliance findings** | ||
| - **Never approve without verifying all quality gates** | ||
|
|
||
| # Reporting | ||
|
|
||
| Upon completion create a summary in `.agent-logs/{agent-name}-{subject}-{unique-id}.md` | ||
| of the project consisting of: | ||
|
|
||
| ```markdown | ||
| # Code Review Report | ||
|
|
||
| **Result**: (SUCCEEDED|FAILED) | ||
|
|
||
| ## Review Summary | ||
|
|
||
| - **Review Set**: [Review set name/identifier] | ||
| - **Review Report File**: [Name of detailed review report generated] | ||
| - **Files Reviewed**: [Count and list of files reviewed] | ||
| - **Review Template Used**: [Template source and version] | ||
|
|
||
| ## Review Results | ||
|
|
||
| - **Overall Conclusion**: [Summary of review results] | ||
| - **Critical Issues**: [Count of critical findings] | ||
| - **High Issues**: [Count of high severity findings] | ||
| - **Medium Issues**: [Count of medium severity findings] | ||
| - **Low Issues**: [Count of low severity findings] | ||
|
|
||
| ## Issue Details | ||
|
|
||
| [For each issue found, include:] | ||
| - **File**: [File name and line number where applicable] | ||
| - **Issue Type**: [Security, logic error, compliance violation, etc.] | ||
| - **Severity**: [Critical/High/Medium/Low] | ||
| - **Description**: [Issue description] | ||
| - **Recommendation**: [Specific remediation recommendation] | ||
|
|
||
| ## Compliance Status | ||
|
|
||
| - **Review Status**: [Complete/Incomplete with reasoning] | ||
| - **Quality Gates**: [Status of review checklist items] | ||
| - **Approval Status**: [Approved/Rejected with justification] | ||
| ``` | ||
|
|
||
| Return summary to caller. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| --- | ||
| name: developer | ||
| description: > | ||
| General-purpose software development agent that applies appropriate standards | ||
| based on the work being performed. | ||
| user-invocable: true | ||
| --- | ||
|
|
||
| # Developer Agent | ||
|
|
||
| Perform software development tasks by determining and applying appropriate DEMA Consulting standards from `.github/standards/`. | ||
|
|
||
| # Standards-Based Workflow | ||
|
|
||
| 1. **Analyze the request** to identify scope: languages, file types, requirements, testing, reviews | ||
| 2. **Read relevant standards** from `.github/standards/` as defined in AGENTS.md based on work performed | ||
| 3. **Apply loaded standards** throughout development process | ||
| 4. **Execute work** following standards requirements and quality checks | ||
| 5. **Generate completion report** with results and compliance status | ||
|
|
||
| # Reporting | ||
|
|
||
| Upon completion create a summary in `.agent-logs/{agent-name}-{subject}-{unique-id}.md` | ||
| of the project consisting of: | ||
|
|
||
| ```markdown | ||
| # Developer Agent Report | ||
|
|
||
| **Result**: (SUCCEEDED|FAILED) | ||
|
|
||
| ## Work Summary | ||
|
|
||
| - **Files Modified**: [List of files created/modified/deleted] | ||
| - **Languages Detected**: [Languages identified] | ||
| - **Standards Applied**: [Standards files consulted] | ||
|
|
||
| ## Tooling Executed | ||
|
|
||
| - **Language Tools**: [Compilers, linters, formatters used] | ||
| - **Compliance Tools**: [ReqStream, ReviewMark tools used] | ||
| - **Validation Results**: [Tool execution results] | ||
|
|
||
| ## Compliance Status | ||
|
|
||
| - **Quality Checks**: [Standards quality checks status] | ||
| - **Issues Resolved**: [Any problems encountered and resolved] | ||
| ``` | ||
|
|
||
| Return this summary to the caller. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.