Add ReviewMark formal code review system from TemplateDotNetLibrary template#117
Merged
Malcolmnixon merged 5 commits intomainfrom Mar 12, 2026
Merged
Conversation
- Add .reviewmark.yaml with TestResults-Model and TestResults-Serialization review-sets - Add demaconsulting.reviewmark v0.1.0-rc.3 to dotnet tools - Add reviewmark tool capture in .versionmark.yaml (pre-release version regex support) - Add .github/agents/code-review-agent.md - Update AGENTS.md with Code Review Agent - Update repo-consistency-agent.md with template tracking guidance - Update build.yaml with ReviewMark steps, plan/report generation, and PDF steps - Add docs/reviewplan/ and docs/reviewreport/ definition files - Update .gitignore and .cspell.json Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update template with latest changes and evaluate review sets
Add ReviewMark formal code review system from TemplateDotNetLibrary template
Mar 12, 2026
Malcolmnixon
requested changes
Mar 12, 2026
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Malcolmnixon
approved these changes
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces the ReviewMark “formal code review” compliance system into the repo (configuration, CI generation of review plan/report documents, and supporting agent/docs scaffolding).
Changes:
- Adds ReviewMark tool/configuration and expands VersionMark capture to include ReviewMark (and pre-release tool versions).
- Updates CI workflow to self-validate ReviewMark and generate Review Plan/Report artifacts (Markdown → HTML → PDF).
- Adds documentation scaffolding and agent guidance for conducting/storing formal file reviews.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
docs/reviewreport/title.txt |
Adds Pandoc metadata for the Review Report PDF. |
docs/reviewreport/introduction.md |
Adds Review Report introduction content. |
docs/reviewreport/definition.yaml |
Adds Pandoc defaults for generating Review Report HTML/PDF. |
docs/reviewplan/title.txt |
Adds Pandoc metadata for the Review Plan PDF. |
docs/reviewplan/introduction.md |
Adds Review Plan introduction content. |
docs/reviewplan/definition.yaml |
Adds Pandoc defaults for generating Review Plan HTML/PDF. |
AGENTS.md |
Registers the new Code Review Agent in the project agent guide. |
.versionmark.yaml |
Updates tool version regexes to support pre-release versions; adds ReviewMark capture. |
.reviewmark.yaml |
Adds ReviewMark review-set definitions and evidence-source configuration. |
.gitignore |
Ignores generated ReviewMark markdown outputs, VersionMark captures, and agent reports. |
.github/workflows/build.yaml |
Adds ReviewMark validation + plan/report generation + HTML/PDF document generation steps. |
.github/agents/repo-consistency-agent.md |
Adds guidance for tracking upstream template evolution. |
.github/agents/code-review-agent.md |
Adds a new agent spec for performing structured formal file reviews. |
.cspell.json |
Adds ReviewMark-related terms to the spell-check dictionary. |
.config/dotnet-tools.json |
Adds demaconsulting.reviewmark as a local dotnet tool dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Malcolmnixon
requested changes
Mar 12, 2026
…anch root Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Malcolmnixon
approved these changes
Mar 12, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs with the latest TemplateDotNetLibrary template by adopting the ReviewMark continuous compliance feature, defining two logical review-sets appropriate for this project.
Review-Sets
TestResults-Model—src/DemaConsulting.TestResults/*.cs(core model classes)TestResults-Serialization—src/DemaConsulting.TestResults/IO/**/*.cs(TRX/JUnit serializers)Changes
Tool & Configuration
.reviewmark.yaml— defines the two review-sets and evidence source (reviewsbranch root).config/dotnet-tools.json— addsdemaconsulting.reviewmarkv0.1.0-rc.3.versionmark.yaml— addsreviewmarkcapture; updates all version regexes to support pre-release semver strings (e.g.0.1.0-rc.3)CI/CD (
build.yaml)Documentation Scaffolding
docs/reviewplan/anddocs/reviewreport/— Pandoc definition files, introductions, and PDF title metadataAgent Infrastructure
.github/agents/code-review-agent.md— new agent for elaborating review-sets and producing structured review reportsAGENTS.md— adds Code Review Agent to available agents and selection guide.github/agents/repo-consistency-agent.md— adds template evolution tracking guidanceHousekeeping
.gitignore— excludes generated review markdown outputs andversionmark-*.json.cspell.json— addsreviewmark,ReviewMark,reviewplan,reviewreportType of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration ReleaseCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
The
reviewsbranch (evidence store for ReviewMark enforcement) does not yet exist — the--enforceflag is not set in the pipeline until that branch is populated with review evidence PDFs and anindex.jsonat the branch root. The evidence source URL points tohttps://raw.githubusercontent.com/demaconsulting/TestResults/reviews/index.json.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.