Skip to content

Update agent files from TemplateDotNetLibrary template improvements#66

Merged
Malcolmnixon merged 4 commits intomainfrom
copilot/update-agent-files-from-template
Mar 23, 2026
Merged

Update agent files from TemplateDotNetLibrary template improvements#66
Malcolmnixon merged 4 commits intomainfrom
copilot/update-agent-files-from-template

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 23, 2026

Transfer of improvements from TemplateDotNetLibrary (PRs #47, #50) to this repo was incomplete — all seven .github/agents/*.md files remained at significantly older, simpler versions. The code-review agent was the most deviated.

Description

Transfer of improvements from TemplateDotNetLibrary (PRs #47, #50) to this repo was incomplete — all seven .github/agents/*.md files remained at significantly older, simpler versions. The code-review agent was the most deviated.

Since this is itself a template repository, agent files are kept as close to the TemplateDotNetLibrary form as possible to maximise consistency across templates and ensure downstream users get files that work with minimal modification.

.github/agents/*.md — Complete rewrites from library

All agent files replaced with comprehensive library versions:

  • code-review: Added ReviewMark integration, structured review execution workflow, cross-agent hand-off patterns, compliance checklist
  • code-quality: Added lint script maintenance responsibility, SonarQube/CodeQL gate details, comprehensive quality enforcement workflow
  • requirements: Added full Continuous Compliance methodology, ReqStream integration, review-set organization patterns (subsystem/class/OTS)
  • software-developer: Added mandatory literate programming style rules, C#/C++ implementation standards with examples, design-for-testability principles
  • technical-writer: Added comprehensive link style rules by file type, Pandoc document structure, Mermaid diagram standards, content longevity principles
  • test-developer: Added C#/C++ test framework standards with examples, CI/CD integration patterns, platform-specific evidence requirements
  • All files gained: user-invocable: true frontmatter, "When to Invoke" sections, "Reporting" sections, "Cross-Agent Coordination" with structured hand-offs, "Compliance Verification Checklist", expanded "Don't Do These Things"

.github/agents/repo-consistency.agent.md — Library version, minimally tool-adapted

Adopted library's comprehensive template-tracking framework with only the minimum necessary tool-specific changes:

  • All TemplateDotNetLibrary references replaced with TemplateDotNetTool
  • "Code Structure and Patterns" uses generic CLI pattern descriptions (matching the library's style) rather than specific file names — CLI Application / Self-Validation / Standard Patterns instead of listing Context.cs, Validation.cs, Program.cs
  • Project configuration references updated for NuGet Tool Package (not library)

AGENTS.md — Incorporated library improvements, preserved tool-specific content

  • Updated agent list descriptions to shorter, cleaner format
  • Rewrote "Agent Selection Guide" → "Agent Selection" using context/goal invocation format
  • Added: "Quality Gate Enforcement (ALL Agents Must Verify)", "Continuous Compliance Overview", "Continuous Compliance Requirements"
  • Preserved all TemplateDotNetTool-specific sections (Tech Stack, Key Files, Build and Test, Key Source Files, Testing, Code Style, etc.)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Pre-Submission Checklist

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.TemplateDotNetTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Documentation-only change. No production code, tests, or requirements modified.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update agent files with recent improvements from sister template Update agent files from TemplateDotNetLibrary template improvements Mar 23, 2026
Copilot AI requested a review from Malcolmnixon March 23, 2026 10:59
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 23, 2026 11:52
Copilot AI review requested due to automatic review settings March 23, 2026 11:52
@Malcolmnixon
Copy link
Copy Markdown
Member

@copilot This is a template repository. As such im wondering whether the files should more follow the TemplateDotNetLibrary form as the expected use of the files here are to be used as templates, so overly customizing to this repo may not be best, but consistency of template agents may be preferable

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this repository’s Copilot agent documentation to the newer, more comprehensive TemplateDotNetLibrary versions, aiming to standardize workflows around Continuous Compliance, quality gates, and cross-agent handoffs.

Changes:

  • Replaced all .github/agents/*.agent.md definitions with expanded versions (reporting, invocation guidance, checklists, coordination).
  • Updated AGENTS.md to modernize agent selection guidance and add Continuous Compliance/quality gate sections.
  • Refreshed the repo-consistency and code-review guidance to incorporate template evolution and ReviewMark concepts.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
AGENTS.md Modernized agent list/selection guidance; added quality gate + Continuous Compliance sections.
.github/agents/test-developer.agent.md Expanded testing guidance (AAA, naming, tooling, CI patterns, coordination).
.github/agents/technical-writer.agent.md Added documentation standards, link-style rules, Pandoc/Mermaid conventions, and compliance checklists.
.github/agents/software-developer.agent.md Expanded literate programming + design-for-testability/compliance guidance and checklists.
.github/agents/requirements.agent.md Added Continuous Compliance/ReqStream methodology, org patterns, enforcement guidance, and checklists.
.github/agents/repo-consistency.agent.md Added a more structured “template evolution intelligence” + handoff/checklist framework.
.github/agents/code-review.agent.md Added ReviewMark-centric review workflow, reporting structure, and cross-agent handoffs.
.github/agents/code-quality.agent.md Expanded quality gate, lint infrastructure ownership, and security/static-analysis guidance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…attern descriptions

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Agent-Logs-Url: https://github.com/demaconsulting/TemplateDotNetTool/sessions/acb5c898-8be7-4afb-bba9-82b31eb57080
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 23, 2026

@copilot This is a template repository. As such im wondering whether the files should more follow the TemplateDotNetLibrary form as the expected use of the files here are to be used as templates, so o...

Good point. The 6 general-purpose agent files (code-review, code-quality, requirements, software-developer, technical-writer, test-developer) were already essentially identical to the library versions with no tool-specific customization.

For repo-consistency.agent.md, the only necessary changes are the template identity references (TemplateDotNetTool instead of TemplateDotNetLibrary). The "Code Structure and Patterns" section previously listed specific filenames (Context.cs, Validation.cs, Program.cs) and argument flags — I've now replaced those with generic descriptions matching the library's style (commit f2f8ddf):

- **CLI Application**: Command-line interface design following .NET CLI tool best practices
- **Self-Validation**: Self-validation pattern for built-in tests
- **Standard Patterns**: Following common CLI tool design patterns

This mirrors the library's approach of Library API / Self-Validation / Standard Patterns, just adapted for CLI tools.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@demaconsulting demaconsulting deleted a comment from Copilot AI Mar 23, 2026
@demaconsulting demaconsulting deleted a comment from Copilot AI Mar 23, 2026
@Malcolmnixon Malcolmnixon merged commit 3ed89a0 into main Mar 23, 2026
15 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/update-agent-files-from-template branch March 23, 2026 14:02
Copilot AI added a commit that referenced this pull request Mar 26, 2026
…teDotNetLibrary PR #66)

Agent-Logs-Url: https://github.com/demaconsulting/TemplateDotNetTool/sessions/f857d5ca-35b8-4bbb-b5ee-fe26dbb234b4

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Malcolmnixon added a commit that referenced this pull request Mar 26, 2026
* Initial plan

* Formalize build_notes.md path and artifact handling (port from TemplateDotNetLibrary PR #66)

Agent-Logs-Url: https://github.com/demaconsulting/TemplateDotNetTool/sessions/f857d5ca-35b8-4bbb-b5ee-fe26dbb234b4

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants