-
Notifications
You must be signed in to change notification settings - Fork 0
Add ReviewMark integration (review plan, review report, multi-set config, ValidationTests) #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a76895a
Initial plan
Copilot 16c6e69
Add ReviewMark integration
Copilot 0277666
Address review feedback: code-review-agent, review sets, gitignore, v…
Copilot 2548e53
Add ValidationTests.cs, link positive tests to requirements, update r…
Copilot 8103c77
Fix ValidationTests: read log file after context disposal to avoid Wi…
Copilot 76ee4cd
Update docs/reviewplan/introduction.md
Malcolmnixon e08e073
TemplateTool-CLI-Review: fix missing positive assertion and incomplet…
Copilot 05647d9
fix: use Guid-based temp paths in IntegrationTests to avoid orphaned …
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| --- | ||
| # ReviewMark Configuration File | ||
| # This file defines which files require review, where the evidence store is located, | ||
| # and how files are grouped into named review-sets. | ||
|
|
||
| # Patterns identifying all files that require review. | ||
| # Processed in order; prefix a pattern with '!' to exclude. | ||
| needs-review: | ||
| - "**/*.cs" | ||
| - "!**/obj/**" | ||
|
|
||
| # Evidence source: review data and index.json are located in the 'reviews' branch | ||
| # of this repository, accessed through the GitHub public HTTPS raw content access. | ||
| # Note: The 'reviews' branch must be created and populated with review evidence PDFs | ||
| # and an index.json before enforcement (--enforce flag) can be enabled in the pipeline. | ||
| evidence-source: | ||
| type: url | ||
| location: https://raw.githubusercontent.com/demaconsulting/TemplateDotNetTool/reviews/index.json | ||
|
|
||
| # Review sets grouping files by logical unit of review. | ||
| reviews: | ||
| - id: TemplateTool-CLI-Review | ||
| title: Review of Template DotNet Tool CLI | ||
| paths: | ||
| - "src/**/Program.cs" | ||
| - "src/**/Context.cs" | ||
|
Malcolmnixon marked this conversation as resolved.
|
||
|
|
||
| - id: TemplateTool-Utilities-Review | ||
| title: Review of Template DotNet Tool Utilities | ||
| paths: | ||
| - "src/**/PathHelpers.cs" | ||
|
Malcolmnixon marked this conversation as resolved.
|
||
| - "src/**/Validation.cs" | ||
|
|
||
| - id: TemplateTool-Tests-Review | ||
|
Malcolmnixon marked this conversation as resolved.
|
||
| title: Review of Template DotNet Tool Tests | ||
| paths: | ||
| - "test/**/*.cs" | ||
| - "!**/obj/**" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| resource-path: | ||
| - docs/reviewplan | ||
| - docs/template | ||
| input-files: | ||
| - docs/reviewplan/title.txt | ||
| - docs/reviewplan/introduction.md | ||
| - docs/reviewplan/review-plan.md | ||
| template: template.html | ||
| table-of-contents: true | ||
| number-sections: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Introduction | ||
|
|
||
| This document contains the review plan for the Template DotNet Tool project. | ||
|
|
||
| ## Purpose | ||
|
|
||
| This review plan provides a comprehensive overview of all files requiring formal review | ||
| in the Template DotNet Tool project. It identifies which review-sets cover which | ||
| files and serves as evidence that every file requiring review is covered by at least | ||
| one named review-set. | ||
|
|
||
| ## Scope | ||
|
|
||
| This review plan covers: | ||
|
|
||
| - C# source code files requiring formal review | ||
| - Mapping of C# source files to named review-sets | ||
|
|
||
| ## Generation Source | ||
|
|
||
| This report is automatically generated by the ReviewMark tool, analyzing the | ||
|
Malcolmnixon marked this conversation as resolved.
Outdated
|
||
| `.reviewmark.yaml` configuration and the review evidence store. It serves as evidence | ||
| that every file requiring review is covered by a current, valid review. | ||
|
|
||
| ## Audience | ||
|
|
||
| This document is intended for: | ||
|
|
||
| - Software developers working on Template DotNet Tool | ||
| - Quality assurance teams validating review coverage | ||
| - Project stakeholders reviewing compliance status | ||
| - Auditors verifying that all required files have been reviewed | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| title: Template DotNet Tool Review Plan | ||
| subtitle: File Review Plan for the Template DotNet Tool | ||
| author: DEMA Consulting | ||
| description: File Review Plan for the Template DotNet Tool | ||
| lang: en-US | ||
| keywords: | ||
| - Template DotNet Tool | ||
| - Review Plan | ||
| - File Reviews | ||
| - .NET | ||
| - Tool | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| resource-path: | ||
| - docs/reviewreport | ||
| - docs/template | ||
| input-files: | ||
| - docs/reviewreport/title.txt | ||
| - docs/reviewreport/introduction.md | ||
| - docs/reviewreport/review-report.md | ||
| template: template.html | ||
| table-of-contents: true | ||
| number-sections: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Introduction | ||
|
|
||
| This document contains the review report for the Template DotNet Tool project. | ||
|
|
||
| ## Purpose | ||
|
|
||
| This review report provides evidence that each review-set is current — the review | ||
| evidence matches the current file fingerprints. It confirms that all formal reviews | ||
| conducted for Template DotNet Tool remain valid for the current state of the | ||
| reviewed files. | ||
|
|
||
| ## Scope | ||
|
|
||
| This review report covers: | ||
|
|
||
| - Current review-set status (current, stale, or missing) | ||
| - File fingerprints and review evidence matching | ||
| - Review coverage verification | ||
|
|
||
| ## Generation Source | ||
|
|
||
| This report is automatically generated by the ReviewMark tool, comparing the current | ||
| file fingerprints against the review evidence store. It serves as evidence that all | ||
| review-sets are current and no reviewed file has changed since its review was conducted. | ||
|
|
||
| ## Audience | ||
|
|
||
| This document is intended for: | ||
|
|
||
| - Software developers working on Template DotNet Tool | ||
| - Quality assurance teams validating review currency | ||
| - Project stakeholders reviewing compliance status | ||
| - Auditors verifying that all reviews remain valid for the current release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| title: Template DotNet Tool Review Report | ||
| subtitle: File Review Report for the Template DotNet Tool | ||
| author: DEMA Consulting | ||
| description: File Review Report for the Template DotNet Tool | ||
| lang: en-US | ||
| keywords: | ||
| - Template DotNet Tool | ||
| - Review Report | ||
| - File Reviews | ||
| - .NET | ||
| - Tool | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.