Skip to content

Extensive improvements based on agent updates#47

Merged
Malcolmnixon merged 9 commits intomainfrom
agent-enhancement
Mar 22, 2026
Merged

Extensive improvements based on agent updates#47
Malcolmnixon merged 9 commits intomainfrom
agent-enhancement

Conversation

@Malcolmnixon
Copy link
Copy Markdown
Member

@Malcolmnixon Malcolmnixon commented Mar 22, 2026

Pull Request

Description

Reorganize Repository Structure for Agent Alignment and Continuous Compliance

Documentation Restructuring:

  • Renamed documentation folders to agent-aligned naming (e.g., docs/reviewplan → docs/code_review_plan)
  • Standardized generated filenames (plan.md, report.md, trace_matrix.md)
  • Consolidated justifications into requirements document structure

Requirements Management:

  • Split monolithic requirements.yaml into organized files in docs/reqstream/
  • Created separate files for library subsystem, platform requirements, and OTS software
  • Maintained ReqStream compatibility with includes directive structure

Configuration Updates:

  • Updated all build workflows and CI/CD paths for new folder structure
  • Fixed 26 markdown linting errors in agent files
  • Enhanced .reviewmark.yaml with logical review-sets and complete file coverage
  • Updated spell-check dictionary and linting configurations

Result: Repository now follows Continuous Compliance best practices with agent-aligned structure, enabling independent reviews and scalable requirements management.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Closes #

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Copilot AI review requested due to automatic review settings March 22, 2026 15:32
@Malcolmnixon
Copy link
Copy Markdown
Member Author

@copilot Please populate the pull request information

Copilot AI mentioned this pull request Mar 22, 2026
22 tasks
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 22, 2026

@Malcolmnixon I've opened a new pull request, #48, to work on those changes. Once the pull request is ready, I'll request review from you.

@Malcolmnixon
Copy link
Copy Markdown
Member Author

@copilot Please fix the quality checks

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 22, 2026

@Malcolmnixon I've opened a new pull request, #49, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR overhauls the repository’s “agent” documentation, expanding it into a Continuous Compliance-oriented guide with more detailed invocation guidance, checklists, and references for specialized agents.

Changes:

  • Reworks AGENTS.md into a Continuous Compliance quick reference with agent selection guidance and quality gates.
  • Expands each specialized agent definition under .github/agents/ with reporting guidance, invocation scenarios, and compliance checklists.
  • Adds/updates Continuous Compliance tool references (ReqStream, ReviewMark, linting suite) across agent docs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
AGENTS.md Replaces project-specific agent notes with a Continuous Compliance-focused quick reference and tool/config overview.
.github/agents/test-developer.agent.md Expands testing guidance (AAA, coverage, traceability, infra examples).
.github/agents/technical-writer.agent.md Adds compliance-ready documentation standards, link-style rules, and verification checklists.
.github/agents/software-developer.agent.md Adds compliance + quality-gate checklists and expands literate/testable coding guidance.
.github/agents/requirements.agent.md Adds extensive Continuous Compliance/ReqStream guidance, organization patterns, and enforcement rules.
.github/agents/repo-consistency.agent.md Expands downstream-template alignment methodology, reporting, and verification checklists.
.github/agents/code-review.agent.md Expands ReviewMark-based workflow, checklists, and reporting guidance.
.github/agents/code-quality.agent.md Expands quality gate enforcement guidance, tooling workflows, and cross-agent coordination.
Comments suppressed due to low confidence (1)

.github/agents/code-quality.agent.md:228

  • This section has a stray closing code fence (```), and the following command lines start with #, which renders as headings instead of a code block. Add the missing opening fence (with language) and keep commands inside it, or remove the unmatched closing fence, so markdown renders correctly and passes linting.
# Run unit tests
dotnet test --configuration Release

# Requirements enforcement
dotnet reqstream --requirements requirements.yaml \
  --tests "test-results/**/*.trx" --enforce

# Run all linters
./lint.sh    # Linux/macOS
lint.bat     # Windows
</details>



---

💡 <a href="/demaconsulting/TemplateDotNetLibrary/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.

Malcolm Nixon and others added 2 commits March 22, 2026 11:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 22, 2026 15:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 22, 2026 17:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 37 out of 50 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 22, 2026 18:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 38 out of 51 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Malcolmnixon Malcolmnixon changed the title Extensive agent improvements. Extensive improvements based on agent updates Mar 22, 2026
@Malcolmnixon Malcolmnixon merged commit 5d7ab8d into main Mar 22, 2026
6 checks passed
@Malcolmnixon Malcolmnixon deleted the agent-enhancement branch March 22, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants