feat: Add ReviewMark integration for formal file reviews#37
feat: Add ReviewMark integration for formal file reviews#37Malcolmnixon merged 7 commits intomainfrom
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Integrates DemaConsulting.ReviewMark into the Continuous Compliance pipeline to generate and publish formal file-review coverage artifacts (Review Plan/Report) during CI runs.
Changes:
- Adds ReviewMark as a dotnet tool and captures its version via VersionMark.
- Introduces
.reviewmark.yamlplus new Review Plan/Report document templates underdocs/. - Extends the build-docs workflow to run ReviewMark self-validation, generate plan/report markdown, and produce PDF artifacts; adds an OTS requirement entry for ReviewMark.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
requirements.yaml |
Adds an OTS requirement for ReviewMark plan/report generation with linked test IDs. |
docs/reviewreport/title.txt |
Adds Pandoc front-matter for the Review Report PDF. |
docs/reviewreport/introduction.md |
Adds template introduction text for the Review Report. |
docs/reviewreport/definition.yaml |
Adds Pandoc defaults to build the Review Report HTML/PDF. |
docs/reviewplan/title.txt |
Adds Pandoc front-matter for the Review Plan PDF. |
docs/reviewplan/introduction.md |
Adds template introduction text for the Review Plan. |
docs/reviewplan/definition.yaml |
Adds Pandoc defaults to build the Review Plan HTML/PDF. |
.versionmark.yaml |
Updates dotnet-tool version regexes to include prerelease suffixes; adds ReviewMark capture. |
.reviewmark.yaml |
Adds ReviewMark configuration (review patterns, evidence source, review-set). |
.github/workflows/build.yaml |
Runs ReviewMark validate + plan/report generation; builds HTML/PDF and uploads PDFs. |
.github/agents/code-review-agent.md |
Adds a formal review agent guide for elaborating a review-set and producing findings. |
.cspell.json |
Adds ReviewMark-related words to spellchecker allowlist. |
.config/dotnet-tools.json |
Adds demaconsulting.reviewmark tool at 0.1.0-rc.2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
@copilot please update ReviewMark to 0.1.0-rc.3 |
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot Please add the two new generated markdown files to the gitignore. Additionally please update the .reviewmark.yaml comment about the evidence source to match the URL (fix the blob access comment). |
…l comment Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Done in dae251c. Added |
|
@copilot Can you run the code-review agent to review the Template-Review review-set. |
The code-review agent completed the Files reviewed (fingerprint
Checklist results:
Observations (non-failures):
Overall Outcome: ✅ Pass — all applicable checks passed. No failures recorded. |
|
@copilot The evidence-source needs to include the index.json |
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Pull Request
Description
Integrates DemaConsulting.ReviewMark into the Continuous Compliance pipeline to provide automated file-review coverage tracking, producing a Review Plan and Review Report as PDF release artifacts on every CI run.
New files
.reviewmark.yaml— defines which C# source files need review (**/*.cs), points to thereviewsbranch as the evidence store (accessed via GitHub public HTTPS raw content atindex.json), and declares a singleTemplate-Reviewreview-setdocs/reviewplan/—title.txt,introduction.md,definition.yamlfor the Review Plan PDFdocs/reviewreport/—title.txt,introduction.md,definition.yamlfor the Review Report PDF.github/agents/code-review-agent.md— agent that elaborates a review-set viadotnet reviewmark --elaborate, applies the checks from the standard review template, and writes anAGENT_REPORT_review-*.mdwith findings only (no file modifications)Updated files
.config/dotnet-tools.json— addsDemaConsulting.ReviewMark 0.1.0-rc.3.versionmark.yaml— captures pre-release version suffixes (alpha/beta/rc) for all dotnet tools, not just ReviewMarkbuild.yaml(build-docsjob) — adds ReviewMark self-validation, generatesreview-plan.md/review-report.md(no--enforceyet — reviews branch not yet populated), Pandoc HTML, and Weasyprint PDF stepsrequirements.yaml— addsTemplate-OTS-ReviewMarkOTS requirement.cspell.json— addsreviewmark,ReviewMark,reviewplan,reviewreport.gitignore— addsdocs/reviewplan/review-plan.mdanddocs/reviewreport/review-report.mdto prevent generated review markdown files from appearing as untracked files on local runsCode Review Agent Run
The
code-review-agentwas executed against theTemplate-Reviewreview-set (fingerprint66194a21...). The following files were reviewed:src/TemplateDotNetLibrary/DemoClass.cstest/TemplateDotNetLibrary.Tests/AssemblyInfo.cstest/TemplateDotNetLibrary.Tests/DemoClassTests.csAll applicable checklist sections (Code Checks and Testing Checks) passed. The full findings are recorded in
AGENT_REPORT_review-Template-Review.md(excluded from git via.gitignore). Overall Outcome: Pass.Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration ReleaseCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
The
Template-OTS-ReviewMarkrequirement inrequirements.yamlis linked toReviewMark_ReviewPlanGenerationandReviewMark_ReviewReportGenerationself-validation tests — these will be satisfied once ReviewMark's self-validation TRX output is confirmed in CI.The
evidence-sourcein.reviewmark.yamlpoints directly toindex.jsonathttps://raw.githubusercontent.com/demaconsulting/TemplateDotNetLibrary/reviews/index.json.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.