Fix stack overflow in AutoLayoutAlgorithm with beta.13 update#41
Merged
Conversation
Beta.13 fixes a critical stack-overflow bug: AutoLayoutAlgorithm's empty-graph (count == 0) fast path unconditionally delegated to HierarchicalLayoutAlgorithm, whose leaf-algorithm resolution only guards against resolving back to itself (not back to auto) - so a graph explicitly declaring CoreOptions.Algorithm = auto (as LayeredPlacement.PlaceWithPorts does) recursed into itself forever once it hit an empty graph, crashing the process with an uncatchable native stack overflow. Reproduced and confirmed in complete isolation from SysML2Tools with a standalone unit test against the Rendering library alone (crashed the test process with STATUS_STACK_OVERFLOW). Confirmed fixed after bumping to beta.13 - both minimal repro models (unconnected and connected parts under an asInterconnectionDiagram view) now render without crashing. Full build/test suite green: 499 Tests x3 TFMs + 355 Tool.Tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
DemaConsulting.Renderingpackage dependencies across the core library, tool, and test projects to the latest beta version (0.1.0-beta.13). This ensures that all components use the most recent features and fixes from the rendering libraries.Dependency updates:
DemaConsulting.Rendering.Layoutto version0.1.0-beta.13inDemaConsulting.SysML2Tools.Core.csprojDemaConsulting.Rendering.SvgandDemaConsulting.Rendering.Skiato version0.1.0-beta.13inDemaConsulting.SysML2Tools.Tool.csprojDemaConsulting.Rendering.SvgandDemaConsulting.Rendering.Skiato version0.1.0-beta.13inDemaConsulting.SysML2Tools.Tests.csproj