Skip to content

Add NTIA validation to self-validation suite#98

Merged
Malcolmnixon merged 4 commits intomainfrom
copilot/add-ntia-validation-check
Dec 15, 2025
Merged

Add NTIA validation to self-validation suite#98
Malcolmnixon merged 4 commits intomainfrom
copilot/add-ntia-validation-check

Conversation

Copy link
Contributor

Copilot AI commented Dec 15, 2025

  • Create ValidateNtia.cs to validate NTIA checking functionality
  • Update Validate.cs to call ValidateNtia.Run() in the self-validation tests
  • Update SelfValidationTests.cs to verify the new NTIA validation test in TRX results
  • Run self-validation to verify the new test works correctly
  • Run full test suite to ensure no regressions
  • Code review completed with no blocking issues
  • CodeQL security scan completed with no vulnerabilities
  • Refactor DoValidate into DoValidateMissingSupplier and DoValidateCompliant
  • Add log output verification to check for specific NTIA error message
  • Add clarifying comment about log file path behavior
Original prompt

This section details on the original issue you should resolve

<issue_title>Add self-validation of NTIA validation</issue_title>
<issue_description>Self-validation is supposed to provide evidence of core functionality, and part of the core functionality is that SpdxTool is capable of performing NTIA validation checks.

An additional self-validation check should be added that verifies NTIA checks can be performed - possibly by having the test write a valid SPDX that isn't NTIA compliant (e.g. missing root packages, missing package supplier, missing package version) and validating the tool reports those failures.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Add self-validation for NTIA validation checks Add NTIA validation to self-validation suite Dec 15, 2025
Copilot AI requested a review from Malcolmnixon December 15, 2025 19:07
Copilot AI and others added 2 commits December 15, 2025 19:14
…utput

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon Malcolmnixon marked this pull request as ready for review December 15, 2025 19:18
Copilot AI requested a review from Malcolmnixon December 15, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add self-validation of NTIA validation

2 participants