Fix for deadlock when running child processes.#66
Merged
Malcolmnixon merged 1 commit intomainfrom Sep 13, 2024
Merged
Conversation
Copilot AI
added a commit
that referenced
this pull request
Mar 24, 2026
- PR #58: Add ReviewMark integration - Added .reviewmark.yaml configuration file - Added demaconsulting.reviewmark to .config/dotnet-tools.json - Updated buildmark to version 0.4.1 - PR #59/#65/#66/#67: Add Code Review Agent - Added .github/agents/code-review.agent.md - Added code-review entry to AGENTS.md agent list and selection guide - PR #61: Apply linting modernization and agent file standardization - Renamed .cspell.json to .cspell.yaml (YAML format with comments) - Renamed .markdownlint-cli2.jsonc to .markdownlint-cli2.yaml (YAML format) - Renamed all agent files to *.agent.md suffix - Updated lint.sh and lint.bat with pip/venv support and new file names - Updated package.json to add cspell and markdownlint-cli2 as devDependencies - Added pip-requirements.txt for yamllint - Updated build.yaml to reference new config file names - PR #63: Enforce cspell word list policy - Added Propagatable, versionmark and other words to .cspell.yaml - PR #64: Align lint YAML configs - Updated .yamllint.yaml with header comments and ignore section - PR #71: Add .gitattributes for LF line endings - Added .gitattributes for consistent line endings across platforms - Also: Updated .gitignore to add Python .venv exclusion
Malcolmnixon
added a commit
that referenced
this pull request
Mar 30, 2026
…s from TemplateDotNetTool (PRs #58–#77 including #65) (#168) * Initial plan * Apply template improvements from TemplateDotNetTool PRs #58-#74 - PR #58: Add ReviewMark integration - Added .reviewmark.yaml configuration file - Added demaconsulting.reviewmark to .config/dotnet-tools.json - Updated buildmark to version 0.4.1 - PR #59/#65/#66/#67: Add Code Review Agent - Added .github/agents/code-review.agent.md - Added code-review entry to AGENTS.md agent list and selection guide - PR #61: Apply linting modernization and agent file standardization - Renamed .cspell.json to .cspell.yaml (YAML format with comments) - Renamed .markdownlint-cli2.jsonc to .markdownlint-cli2.yaml (YAML format) - Renamed all agent files to *.agent.md suffix - Updated lint.sh and lint.bat with pip/venv support and new file names - Updated package.json to add cspell and markdownlint-cli2 as devDependencies - Added pip-requirements.txt for yamllint - Updated build.yaml to reference new config file names - PR #63: Enforce cspell word list policy - Added Propagatable, versionmark and other words to .cspell.yaml - PR #64: Align lint YAML configs - Updated .yamllint.yaml with header comments and ignore section - PR #71: Add .gitattributes for LF line endings - Added .gitattributes for consistent line endings across platforms - Also: Updated .gitignore to add Python .venv exclusion * Add TemplateDotNetTool to cspell word list Referenced in AGENTS.md consistency guidance. * Fix reviewmark.yaml paths, cleanup cspell wordlist, and fix lint.sh variable naming Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> Agent-Logs-Url: https://github.com/demaconsulting/SpdxTool/sessions/70daa113-6d7e-4a84-929f-1b125a5aeed8 * Apply TemplateDotNetTool PR #75, #76, #77 improvements PR #75 - Formalize build_notes.md path and artifact handling: - technical-writer.agent.md: Update docs structure to show build_notes.md at docs/ level and build_notes/ folder for versions.md - release.yaml: Remove 'Move buildnotes.md to root' step, use artifact path directly (artifacts/buildnotes.md) for release body PR #76 - Agent and lint cleanup: - .cspell.yaml: Add **/.agent-logs/** to ignorePaths - .markdownlint-cli2.yaml: Add noBanner/noProgress options and **/.agent-logs/** to ignores - .yamllint.yaml: Add .agent-logs/ to ignore list - .gitignore: Add .agent-logs/ directory - lint.sh: Lowercase LINT_ERROR variable, add --silent/--quiet flags - lint.bat: Add --silent/--quiet flags to npm/pip/cspell - Delete code-quality.agent.md (replaced by quality.agent.md) - Create quality.agent.md with standards-based quality assessment - Create developer.agent.md for general-purpose development - Create implementation.agent.md for orchestrated implementations - Update code-review.agent.md with new reporting to .agent-logs/ - Update repo-consistency.agent.md with mandatory workflow steps - Update reporting sections in requirements/software-developer/ technical-writer/test-developer agents to use .agent-logs/ - Update @code-quality references to @quality across all agents - Create .github/standards/ directory with 6 standards files: csharp-language.md, csharp-testing.md, reqstream-usage.md, reviewmark-usage.md, software-items.md, technical-documentation.md - AGENTS.md: Add standards application section, agent delegation guidelines, restructure available agents list, update reporting PR #77 - Markdown format requirements (included in technical-documentation.md) Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> * Sync quality-checks CI job with TemplateDotNetTool pattern Replace individual linting GitHub Actions (markdownlint-cli2-action, cspell-action, ibiqlik/action-yamllint) with Setup Node.js, Setup Python, and bash ./lint.sh steps to align CI with the local lint script and the TemplateDotNetTool template pattern. This ensures the linting run in CI exactly matches what developers can run locally, preventing drift between local and CI lint behavior. Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> * Changes before error encountered Agent-Logs-Url: https://github.com/demaconsulting/SpdxTool/sessions/0750abd2-5d0e-44a2-9bde-eb84bf3f589b Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> * Apply TemplateDotNetTool PR #65: remove legacy agents, fix paths, update docs structure Agent-Logs-Url: https://github.com/demaconsulting/SpdxTool/sessions/f9c074e6-a286-4d90-b44e-98b5b9bd78a8 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> * Fix Windows test failure: normalize TRX file line endings before Assert.Contains The .gitattributes change (eol=lf) causes .cs files to be checked out with LF on Windows. The raw string literal in the test then has LF, but the TRX file generated at runtime on Windows has CRLF. This caused Assert.Contains to fail when searching for the LF substring in the CRLF content. Fix by normalizing line endings in the read results string. Agent-Logs-Url: https://github.com/demaconsulting/SpdxTool/sessions/8ee39b14-6a76-47ac-971b-9783e04e67e1 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #67 by modifying how the console output of child processes is read to prevent the deadlock.