Apply formal review fixes and documentation updates across all groups

.config/dotnet-tools.json

@@ -2,59 +2,82 @@
   "version": 1,
   "isRoot": true,
   "tools": {
-    "dotnet-sonarscanner": {
-      "version": "11.2.1",
-      "commands": [
-        "dotnet-sonarscanner"
-      ]
-    },
     "demaconsulting.pandoctool": {
       "version": "3.9.0.2",
       "commands": [
         "pandoc"
-      ]
+      ],
+      "rollForward": false
     },
     "demaconsulting.weasyprinttool": {
       "version": "68.1.0",
       "commands": [
         "weasyprint"
-      ]
-    },
-    "demaconsulting.sonarmark": {
-      "version": "1.5.0",
-      "commands": [
-        "sonarmark"
-      ]
+      ],
+      "rollForward": false
     },
     "demaconsulting.sarifmark": {
       "version": "1.3.2",
       "commands": [
         "sarifmark"
-      ]
+      ],
+      "rollForward": false
+    },
+    "demaconsulting.sonarmark": {
+      "version": "1.5.0",
+      "commands": [
+        "sonarmark"
+      ],
+      "rollForward": false
     },
     "demaconsulting.reqstream": {
       "version": "1.10.0",
       "commands": [
         "reqstream"
-      ]
+      ],
+      "rollForward": false
     },
     "demaconsulting.buildmark": {
       "version": "1.2.2",
       "commands": [
         "buildmark"
-      ]
+      ],
+      "rollForward": false
     },
     "demaconsulting.versionmark": {
       "version": "1.4.3",
       "commands": [
         "versionmark"
-      ]
+      ],
+      "rollForward": false
     },
     "demaconsulting.reviewmark": {
       "version": "1.2.0",
       "commands": [
         "reviewmark"
-      ]
+      ],
+      "rollForward": false
+    },
+    "demaconsulting.fileassert": {
+      "version": "0.3.0",
+      "commands": [
+        "fileassert"
+      ],
+      "rollForward": false
+    },
+    "demaconsulting.dictionarymark": {
+      "version": "0.1.0-beta.1",
+      "commands": [
+        "dictionarymark"
+      ],
+      "rollForward": false
+    },
+    "dotnet-sonarscanner": {
+      "version": "11.2.1",
+      "commands": [
+        "dotnet-sonarscanner"
+      ],
+      "rollForward": false
     }
   }
 }

.cspell.yaml

@@ -5,27 +5,28 @@
 # - Maintain professional documentation and code quality
 # - Catch spelling errors before publication
 # - Support consistent technical terminology usage
-# - Misspelled words should be fixed in the source
-# - NEVER add a misspelled word to the 'words' list
+# - NEVER add a misspelled word - fix the typo in the source instead
+# - NEVER add a British-English spelling - correct to US-English in the source
 # - PROPOSE only genuine technical terms/names as needed
-
-version: "0.2"
+version: '0.2'
 language: en
-
 # Project-specific technical terms and tool names
 words:
   - Anson
+  - behaviour
   - Blockquotes
   - buildmark
   - BuildMark
   - build_notes
   - buildMultiTargeting
   - camelcase
+  - Centralising
   - Checkmarx
   - code_quality
   - code_review_plan
   - code_review_report
   - CodeQL
+  - colour
   - copilot
   - cspell
   - csproj
@@ -37,6 +38,8 @@ words:
   - DEMACONSULTINGNUGETKEY
   - Dependabot
   - dependabot
+  - devtoolof
+  - displayname
   - doctitle
   - dotnet
   - dotnettool
@@ -48,9 +51,11 @@ words:
   - gitignore
   - hotspots
   - ibiqlik
+  - invalidoption
   - LINQ
   - maintainer
   - markdownlint
+  - metacharacters
   - mermaid
   - MSBUILD
   - MSBUILDDISABLENODEREUSE
@@ -59,6 +64,8 @@ words:
   - myterm
   - ncipollo
   - NOASSERTION
+  - notools
+  - noversion
   - ntia
   - nuget
   - nupkg
@@ -77,6 +84,7 @@ words:
   - reviewmark
   - ReviewMark
   - rezip
+  - rollup
   - sandboxed
   - Sarif
   - SarifMark
@@ -100,37 +108,36 @@ words:
   - streetsidesoftware
   - templatetool
   - TemplateDotNetTool
+  - testtoolof
   - testname
   - TMPL
   - trace_matrix
   - triaging
   - Trivy
   - trx
+  - validfile
   - vbproj
   - vcxproj
   - versionmark
+  - xunit
+  - Xunit
   - VersionMark
   - Weasyprint
+  - withtools
   - wildcards
   - YamlDotNet
+  - yamlfix
   - yamllint
-
 # Exclude common build artifacts, dependencies, and vendored third-party code
 ignorePaths:
-  - "**/.git/**"
-  - "**/node_modules/**"
-  - "**/.venv/**"
-  - "**/thirdparty/**"
-  - "**/third-party/**"
-  - "**/3rd-party/**"
-  - "**/AGENT_REPORT_*.md"
-  - "**/.agent-logs/**"
-  - "**/bin/**"
-  - "**/obj/**"
-  - "*.nupkg"
-  - "*.snupkg"
-  - "*.dll"
-  - "*.exe"
-  - "*.trx"
-  - "*.spdx.json"
+  - '**/.git/**'
+  - '**/node_modules/**'
+  - '**/.venv/**'
+  - '**/thirdparty/**'
+  - '**/third-party/**'
+  - '**/3rd-party/**'
+  - '**/.agent-logs/**'
+  - '**/bin/**'
+  - '**/obj/**'
+  - '**/generated/**'
   - package-lock.json

.editorconfig

@@ -5,7 +5,7 @@ root = true
 
 # All files
 [*]
-charset = utf-8-bom
+charset = utf-8
 end_of_line = lf
 indent_style = space
 indent_size = 4
@@ -36,8 +36,6 @@ indent_size = 4
 csharp_prefer_braces = true:warning
 csharp_prefer_simple_using_statement = true:suggestion
 csharp_style_namespace_declarations = file_scoped:warning
-csharp_style_prefer_method_group_conversion = true:silent
-csharp_style_prefer_top_level_statements = true:silent
 csharp_style_expression_bodied_methods = false:silent
 csharp_style_expression_bodied_constructors = false:silent
 csharp_style_expression_bodied_operators = false:silent
@@ -47,7 +45,7 @@ csharp_style_expression_bodied_accessors = true:silent
 csharp_style_expression_bodied_lambdas = true:silent
 csharp_style_expression_bodied_local_functions = false:silent
 
-# Naming Conventions
+# Naming conventions
 dotnet_naming_rule.interface_should_be_begins_with_i.severity = warning
 dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
 dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
@@ -63,57 +61,22 @@ dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
 # Symbol specifications
 dotnet_naming_symbols.interface.applicable_kinds = interface
 dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
-dotnet_naming_symbols.interface.required_modifiers = 
 
 dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
 dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
-dotnet_naming_symbols.types.required_modifiers = 
 
 dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
 dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
-dotnet_naming_symbols.non_field_members.required_modifiers = 
 
 # Naming styles
 dotnet_naming_style.begins_with_i.required_prefix = I
-dotnet_naming_style.begins_with_i.required_suffix = 
-dotnet_naming_style.begins_with_i.word_separator = 
 dotnet_naming_style.begins_with_i.capitalization = pascal_case
 
-dotnet_naming_style.pascal_case.required_prefix = 
-dotnet_naming_style.pascal_case.required_suffix = 
-dotnet_naming_style.pascal_case.word_separator = 
 dotnet_naming_style.pascal_case.capitalization = pascal_case
 
 # Organize usings
 dotnet_sort_system_directives_first = true
 dotnet_separate_import_directive_groups = false
 
-# Code quality - set to suggestion to not break existing code
-dotnet_code_quality_unused_parameters = all:suggestion
-
 # Nullable reference types
 csharp_nullable_reference_types = enable
-
-# Suppress specific CA rules
-dotnet_diagnostic.CA1303.severity = none  # Do not pass literals as localized parameters (not localizing)
-dotnet_diagnostic.CA2007.severity = none  # Do not directly await a Task (library code, not UI)
-dotnet_diagnostic.CA1062.severity = none  # Validate arguments of public methods (nullable context handles this)
-dotnet_diagnostic.CA1031.severity = none  # Do not catch general exception types (needed for top-level error handling)
-dotnet_diagnostic.CA1716.severity = none  # Identifiers should not match keywords (existing API)
-dotnet_diagnostic.CA1310.severity = none  # Specify StringComparison for correctness (to be fixed incrementally)
-dotnet_diagnostic.CA1305.severity = none  # Specify IFormatProvider (not localizing)
-dotnet_diagnostic.CA1307.severity = none  # Specify StringComparison for string methods (to be fixed incrementally)
-dotnet_diagnostic.CA1308.severity = none  # Normalize to uppercase (existing behavior, not security critical)
-dotnet_diagnostic.CA1515.severity = none  # Make types internal (public API by design)
-dotnet_diagnostic.CA1054.severity = none  # URI parameters should not be strings (existing API)
-dotnet_diagnostic.CA1872.severity = none  # Use modern API (to be evaluated for .NET compatibility)
-dotnet_diagnostic.CA2000.severity = none  # Dispose objects before losing scope (HttpClient handles disposal)
-dotnet_diagnostic.CA1707.severity = none  # Identifiers should not contain underscores (test naming convention)
-dotnet_diagnostic.CA1819.severity = none  # Properties should not return arrays (existing API, immutable)
-dotnet_diagnostic.CA1032.severity = none  # Exception constructors (simplified exceptions)
-dotnet_diagnostic.CA2234.severity = none  # Pass System.Uri instead of string (existing API)
-dotnet_diagnostic.CA5399.severity = none  # Enable certificate revocation check (to be evaluated separately)
-
-# Suppress warnings for generated code
-[**/obj/**/*.cs]
-generated_code = true