Skip to content

Sync AGENTS.md, agent definitions, standards, and lint scripts from TemplateDotNetTool - #179

Merged
Malcolmnixon merged 1 commit into
mainfrom
copilot/copy-updated-files-from-template
Apr 12, 2026
Merged

Malcolmnixon merged 1 commit into
mainfrom
copilot/copy-updated-files-from-template

Conversation

Copilot AI commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Binary-copy updated files from demaconsulting/TemplateDotNetTool to bring this repo in sync with the latest template.

Changes

  • AGENTS.md — references two new standards files (coding-principles.md, testing-principles.md)
  • .github/agents/*.md — updated all 5 agent definitions
  • .github/standards/coding-principles.md (new) — universal coding standards (literate programming, architecture patterns, anti-patterns)
  • .github/standards/testing-principles.md (new) — universal testing standards (hierarchy boundaries, AAA pattern)
  • .github/standards/*.md — updated 7 existing standards files (csharp-language, csharp-testing, design-documentation, reqstream-usage, reviewmark-usage, software-items, technical-documentation)
  • lint.sh / lint.bat — updated lint scripts

All files downloaded verbatim from template commit 18e8bff via curl.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.SpdxTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No code changes — agent/standards/lint files only.

@Malcolmnixon
Malcolmnixon marked this pull request as ready for review April 12, 2026 02:29
Copilot AI review requested due to automatic review settings April 12, 2026 02:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Synchronizes this repository’s agent guidance, standards documentation, and lint scripts with the latest TemplateDotNetTool template (commit 18e8bff) to keep Continuous Compliance workflows consistent across downstream repos.

Changes:

  • Added universal standards docs: coding-principles.md and testing-principles.md, and updated existing standards to reference them.
  • Updated all 5 .github/agents/*.md definitions (notably quality checklist now includes hierarchy boundary checks).
  • Enhanced lint.sh / lint.bat to (1) skip Puppeteer downloads during npm install and (2) run dotnet tool-based lints (ReqStream/VersionMark/ReviewMark) before dotnet format.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
AGENTS.md Updates project placeholders and expands the standards list to include the new universal principles docs.
lint.sh Adds Puppeteer skip-download and introduces dotnet tool restore + reqstream/versionmark/reviewmark lint steps; runs dotnet format with --no-restore.
lint.bat Windows equivalent of the updated lint flow, with section-level abort handling and added dotnet linting steps.
.github/agents/code-review.agent.md Syncs formal review agent definition with template guidance and reporting format.
.github/agents/developer.agent.md Syncs developer agent workflow/reporting expectations to current standards-based process.
.github/agents/implementation.agent.md Syncs orchestrator/state-machine description and reporting template.
.github/agents/quality.agent.md Adds testing boundary checks to the quality report template; relocates Result semantics guidance.
.github/agents/repo-consistency.agent.md Syncs template-alignment workflow guidance and reporting format.
.github/standards/coding-principles.md New universal coding principles and quality gates.
.github/standards/testing-principles.md New universal testing principles, including hierarchy dependency boundaries and AAA requirement.
.github/standards/csharp-language.md Adds front matter and re-scopes content to reference universal coding principles + formatting/quality checks.
.github/standards/csharp-testing.md Adds front matter and required-standards section; aligns test guidance with universal testing principles.
.github/standards/design-documentation.md Adds front matter + required standards; clarifies scope exclusions for design docs.
.github/standards/reqstream-usage.md Adds front matter + required standards; clarifies downward-only requirement linking language.
.github/standards/reviewmark-usage.md Adds front matter + required standards reference.
.github/standards/software-items.md Adds front matter; clarifies subsystem/unit definitions and testing expectations.
.github/standards/technical-documentation.md Adds front matter and clarifies “References” section constraints (external specs only).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants