Repository navigation
Sync AGENTS.md, agent definitions, standards, and lint scripts from TemplateDotNetTool - #179
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/demaconsulting/SpdxTool/sessions/2c492aa9-624f-400d-b838-c8671ba8c380 Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Malcolmnixon
April 12, 2026 02:29
View session
Malcolmnixon
marked this pull request as ready for review
April 12, 2026 02:29
Contributor
There was a problem hiding this comment.
Pull request overview
Synchronizes this repository’s agent guidance, standards documentation, and lint scripts with the latest TemplateDotNetTool template (commit 18e8bff) to keep Continuous Compliance workflows consistent across downstream repos.
Changes:
- Added universal standards docs:
coding-principles.mdandtesting-principles.md, and updated existing standards to reference them. - Updated all 5
.github/agents/*.mddefinitions (notably quality checklist now includes hierarchy boundary checks). - Enhanced
lint.sh/lint.batto (1) skip Puppeteer downloads during npm install and (2) run dotnet tool-based lints (ReqStream/VersionMark/ReviewMark) beforedotnet format.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Updates project placeholders and expands the standards list to include the new universal principles docs. |
| lint.sh | Adds Puppeteer skip-download and introduces dotnet tool restore + reqstream/versionmark/reviewmark lint steps; runs dotnet format with --no-restore. |
| lint.bat | Windows equivalent of the updated lint flow, with section-level abort handling and added dotnet linting steps. |
| .github/agents/code-review.agent.md | Syncs formal review agent definition with template guidance and reporting format. |
| .github/agents/developer.agent.md | Syncs developer agent workflow/reporting expectations to current standards-based process. |
| .github/agents/implementation.agent.md | Syncs orchestrator/state-machine description and reporting template. |
| .github/agents/quality.agent.md | Adds testing boundary checks to the quality report template; relocates Result semantics guidance. |
| .github/agents/repo-consistency.agent.md | Syncs template-alignment workflow guidance and reporting format. |
| .github/standards/coding-principles.md | New universal coding principles and quality gates. |
| .github/standards/testing-principles.md | New universal testing principles, including hierarchy dependency boundaries and AAA requirement. |
| .github/standards/csharp-language.md | Adds front matter and re-scopes content to reference universal coding principles + formatting/quality checks. |
| .github/standards/csharp-testing.md | Adds front matter and required-standards section; aligns test guidance with universal testing principles. |
| .github/standards/design-documentation.md | Adds front matter + required standards; clarifies scope exclusions for design docs. |
| .github/standards/reqstream-usage.md | Adds front matter + required standards; clarifies downward-only requirement linking language. |
| .github/standards/reviewmark-usage.md | Adds front matter + required standards reference. |
| .github/standards/software-items.md | Adds front matter; clarifies subsystem/unit definitions and testing expectations. |
| .github/standards/technical-documentation.md | Adds front matter and clarifies “References” section constraints (external specs only). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binary-copy updated files from demaconsulting/TemplateDotNetTool to bring this repo in sync with the latest template.
Changes
coding-principles.md,testing-principles.md).github/agents/*.md— updated all 5 agent definitions.github/standards/coding-principles.md(new) — universal coding standards (literate programming, architecture patterns, anti-patterns).github/standards/testing-principles.md(new) — universal testing standards (hierarchy boundaries, AAA pattern).github/standards/*.md— updated 7 existing standards files (csharp-language,csharp-testing,design-documentation,reqstream-usage,reviewmark-usage,software-items,technical-documentation)lint.sh/lint.bat— updated lint scriptsAll files downloaded verbatim from template commit
18e8bffviacurl.Type of Change
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.SpdxTool --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
./lint.sh(Unix/macOS) orcmd /c lint.bat/./lint.bat(Windows)Testing
Documentation
Additional Notes
No code changes — agent/standards/lint files only.