Skip to content

Sync AGENTS.md, agent definitions, and standards from TemplateDotNetTool#173

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/update-files-from-template
Apr 1, 2026
Merged

Sync AGENTS.md, agent definitions, and standards from TemplateDotNetTool#173
Malcolmnixon merged 2 commits intomainfrom
copilot/update-files-from-template

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

Pull Request

Description

Brings agent and standards files into alignment with the upstream TemplateDotNetTool template. No stale agents were found; the existing five agent files were updated in place and one new standards file was added.

Files updated:

  • AGENTS.md — root agent quick-reference
  • .github/agents/ — all five agent definitions updated (code-review, developer, implementation, quality, repo-consistency)
  • .github/standards/csharp-testing.md, reqstream-usage.md, reviewmark-usage.md, technical-documentation.md — updated to template versions
  • .github/standards/design-documentation.mdnew file introduced by template

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.SpdxTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

All files were copied verbatim from the template; no SpdxTool-specific adaptations were made. Lint suite passed post-update.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

- Update AGENTS.md to template version
- Update all .github/agents/*.md agent files
- Update .github/standards/csharp-testing.md
- Update .github/standards/reqstream-usage.md
- Update .github/standards/reviewmark-usage.md
- Update .github/standards/technical-documentation.md
- Add new .github/standards/design-documentation.md

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Update files from template repository Sync AGENTS.md, agent definitions, and standards from TemplateDotNetTool Apr 1, 2026
Copilot AI requested a review from Malcolmnixon April 1, 2026 12:46
@Malcolmnixon Malcolmnixon marked this pull request as ready for review April 1, 2026 13:17
Copilot AI review requested due to automatic review settings April 1, 2026 13:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns this repository’s agent definitions and standards documentation with the upstream TemplateDotNetTool Continuous Compliance template.

Changes:

  • Updated AGENTS.md to reference the standardized Continuous Compliance agent workflow and standards set (including new design documentation standards).
  • Synced all five .github/agents/*.agent.md definitions to the template format (notably report filename conventions and updated checklists/templates).
  • Updated standards docs under .github/standards/ and added the new design-documentation.md standard.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
AGENTS.md Updates agent quick reference to template-based Continuous Compliance guidance and standards list.
.github/standards/technical-documentation.md Updates the “docs/ layout” standard (now includes design/reqstream structure).
.github/standards/reviewmark-usage.md Updates ReviewMark standards/examples and recommended needs-review patterns.
.github/standards/reqstream-usage.md Updates ReqStream organization guidance and hierarchy rules.
.github/standards/design-documentation.md Adds new design documentation standards and required structure guidance.
.github/standards/csharp-testing.md Minor terminology/spelling normalization (“anti-patterns”).
.github/agents/repo-consistency.agent.md Updates template-alignment wording and report template conventions.
.github/agents/quality.agent.md Replaces checklist block with a structured PASS/FAIL/N/A reporting template.
.github/agents/implementation.agent.md Updates sub-agent call wording and report template conventions.
.github/agents/developer.agent.md Updates report path format and result formatting conventions.
.github/agents/code-review.agent.md Updates review report output path format and report template conventions.
Comments suppressed due to low confidence (1)

.github/standards/technical-documentation.md:56

  • This standards doc defines a docs/design/, docs/reqstream/, and docs/user_guide/ structure, but this repository currently has no docs/design/ or docs/reqstream/ directories and uses docs/guide/ instead. As written, this will misdirect contributors/agents and contradict the current repo layout; either update the folder structure in the repo as part of this change, or adjust this document to describe the repo’s actual documentation/requirements layout (and optionally include a migration note).
  design/                      # Design documentation
    introduction.md            # Design overview
    system.md                  # System architecture
    {subsystem-name}/          # Subsystem design folder
      {subsystem-name}.md      # Subsystem-specific designs
      {unit-name}.md           # Unit-specific designs
    {unit-name}.md             # Top-level unit design
  reqstream/                   # Requirements source files
    system.yaml                # System requirements
    platform-requirements.yaml # Platform requirements
    {subsystem-name}/          # Subsystem requirements folder
      {subsystem-name}.yaml    # Subsystem requirements
      {unit-name}.yaml         # Unit requirements
    ots/                       # OTS requirement files
      {ots-name}.yaml          # OTS requirements
  requirements_doc/            # Auto-generated requirements reports
    requirements.md            # Generated by ReqStream
    justifications.md          # Generated by ReqStream
  requirements_report/         # Auto-generated trace matrices
    trace_matrix.md            # Generated by ReqStream
  user_guide/                  # User-facing documentation
    introduction.md            # User guide overview
    {section}.md               # User guide sections

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants