Skip to content

Fix build job name to match template convention#163

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/fix-build-job-name-convention
Mar 5, 2026
Merged

Fix build job name to match template convention#163
Malcolmnixon merged 2 commits intomainfrom
copilot/fix-build-job-name-convention

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 5, 2026

Pull Request

Description

Both build_on_push.yaml and release.yaml were overriding the build job name to "Build and Test" instead of "Build" as defined in the TemplateDotNetTool convention.

  • .github/workflows/build_on_push.yaml: name: Build and Testname: Build
  • .github/workflows/release.yaml: name: Build and Testname: Build

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Closes #

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.SpdxTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

No functional impact — this is a naming consistency fix to align with the TemplateDotNetTool convention.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…uild)

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix build job name to follow template convention Fix build job name to match template convention Mar 5, 2026
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 5, 2026 14:37
Copilot AI review requested due to automatic review settings March 5, 2026 14:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns GitHub Actions workflow job naming with the TemplateDotNetTool convention by updating the build job display name from “Build and Test” to “Build”, improving consistency across workflows without changing behavior.

Changes:

  • Update build job name in the release workflow to Build
  • Update build job name in the push workflow to Build

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yaml Renames the build job display name to match the shared template convention.
.github/workflows/build_on_push.yaml Renames the build job display name to match the shared template convention.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants